Skip to content

Commit 373cef3

Browse files
committed
cask/audit: always run min_os audit
1 parent febcc79 commit 373cef3

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Library/Homebrew/cask/audit.rb

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -768,13 +768,15 @@ def audit_livecheck_version
768768
sig { void }
769769
def audit_min_os
770770
return unless online?
771-
return unless strict?
772771

773772
odebug "Auditing minimum macOS version"
774773

775774
bundle_min_os = cask_bundle_min_os
776775
sparkle_min_os = cask_sparkle_min_os
777776

777+
puts "Bundle min os:", bundle_min_os
778+
puts "Sparkle min os:", sparkle_min_os
779+
778780
app_min_os = [bundle_min_os, sparkle_min_os].compact.max
779781
debug_messages = []
780782
debug_messages << "from artifact: #{bundle_min_os.to_sym}" if bundle_min_os
@@ -786,6 +788,8 @@ def audit_min_os
786788
depends_on_min_os = cask.depends_on.macos&.minimum_version
787789

788790
cask_min_os = [on_system_block_min_os, depends_on_min_os].compact.max
791+
puts "Cask min os:", cask_min_os
792+
puts "App min os:", app_min_os
789793
debug_messages = []
790794
debug_messages << "from on_system block: #{on_system_block_min_os.to_sym}" if on_system_block_min_os
791795
if depends_on_min_os > HOMEBREW_MACOS_OLDEST_ALLOWED
@@ -811,8 +815,7 @@ def audit_min_os
811815
end
812816
source = T.must(bundle_min_os.to_s <=> sparkle_min_os.to_s).positive? ? "Artifact" : "Upstream"
813817
add_error "#{source} defined #{app_min_os.to_sym.inspect} as the minimum macOS version " \
814-
"but the cask declared #{min_os_definition}",
815-
strict_only: true
818+
"but the cask declared #{min_os_definition}"
816819
end
817820

818821
sig { returns(T.nilable(MacOSVersion)) }

0 commit comments

Comments
 (0)