From 1370420a589800a9a0e0918fb3f147f0175405fa Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Thu, 3 Apr 2025 21:10:00 -0400 Subject: [PATCH] Fix clippy This removes some extra unnecessary semicolons that `clippy` has recently begun to catch, causing CI to fail with errors such as: error: unnecessary semicolon --> gix-transport/src/client/blocking_io/http/traits.rs:30:18 | 30 | }; | ^ help: remove | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon = note: `-D clippy::unnecessary-semicolon` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_semicolon)]` While it looks like this might first have been observed in #1917, it is unrelated to any change there. It happens when the current tip of main (4660f7a) is rerun, as observed in: https://github.com/EliahKagan/gitoxide/actions/runs/14254079128/job/39958292846 This runs `just clippy-fix` and `etc/copy-packetline.sh` to fix it. --- gix-packetline-blocking/src/read/sidebands/async_io.rs | 6 +++--- gix-packetline/src/read/sidebands/async_io.rs | 6 +++--- gix-transport/src/client/blocking_io/http/traits.rs | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/gix-packetline-blocking/src/read/sidebands/async_io.rs b/gix-packetline-blocking/src/read/sidebands/async_io.rs index 9a9ddc9dff6..6ffe200590d 100644 --- a/gix-packetline-blocking/src/read/sidebands/async_io.rs +++ b/gix-packetline-blocking/src/read/sidebands/async_io.rs @@ -302,7 +302,7 @@ where "interrupted by user", ))) } - }; + } } BandRef::Error(d) => { let text = TextRef::from(d).0; @@ -314,9 +314,9 @@ where "interrupted by user", ))) } - }; + } } - }; + } } None => { break match line.as_slice() { diff --git a/gix-packetline/src/read/sidebands/async_io.rs b/gix-packetline/src/read/sidebands/async_io.rs index cd563bfc601..1a04a381254 100644 --- a/gix-packetline/src/read/sidebands/async_io.rs +++ b/gix-packetline/src/read/sidebands/async_io.rs @@ -300,7 +300,7 @@ where "interrupted by user", ))) } - }; + } } BandRef::Error(d) => { let text = TextRef::from(d).0; @@ -312,9 +312,9 @@ where "interrupted by user", ))) } - }; + } } - }; + } } None => { break match line.as_slice() { diff --git a/gix-transport/src/client/blocking_io/http/traits.rs b/gix-transport/src/client/blocking_io/http/traits.rs index b390eecc45a..df00b2a4bd8 100644 --- a/gix-transport/src/client/blocking_io/http/traits.rs +++ b/gix-transport/src/client/blocking_io/http/traits.rs @@ -27,7 +27,7 @@ impl crate::IsSpuriousError for Error { #[cfg(feature = "http-client-reqwest")] if let Some(err) = source.downcast_ref::() { return err.is_spurious(); - }; + } false } _ => false,