From ef21b2e169df8c9ac250cb88ed75ec0a974bf865 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Mon, 12 Aug 2024 03:52:00 -0400 Subject: [PATCH 1/2] Try MSRV workflow on newer runner OS versions --- .github/workflows/msrv.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/msrv.yml b/.github/workflows/msrv.yml index 5ed7ba30fc9..fb7bd5c1e90 100644 --- a/.github/workflows/msrv.yml +++ b/.github/workflows/msrv.yml @@ -19,8 +19,8 @@ jobs: strategy: matrix: os: - - windows-2019 - - ubuntu-latest + - windows-2022 + - ubuntu-24.04 runs-on: ${{ matrix.os }} env: # dictated by `firefox` to support the `helix` editor, but now probably effectively be controlled by `jiff`, which also aligns with `regex`. From ee214c19d8f38ee74005cd50771f51c70ebcd439 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Mon, 12 Aug 2024 03:55:39 -0400 Subject: [PATCH 2/2] Put Ubuntu runner back to rolling for MSRV workflow As of this commit, `ubuntu-latest` is `ubuntu-22.04`, with the `ubuntu-24.04` runner image having beta status (even though Ubuntu 24.04 LTS is released), and `windows-latest` is `windows-2022`. So this is putting Ubuntu back to 22.04, but it will automatically become 24.04 evenutally, which the previous commit checks is likely to work (since it would work now). As detailed in #1514, there have not been problems in the past with new Ubuntu versions on GHA runners breaking this workflow. In contrast, there have been such problems with the Windows runners, so this keeps the pin adjusted to the newer version, but it does not change it to rolling. --- .github/workflows/msrv.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/msrv.yml b/.github/workflows/msrv.yml index fb7bd5c1e90..2a70104b7bc 100644 --- a/.github/workflows/msrv.yml +++ b/.github/workflows/msrv.yml @@ -20,7 +20,7 @@ jobs: matrix: os: - windows-2022 - - ubuntu-24.04 + - ubuntu-latest runs-on: ${{ matrix.os }} env: # dictated by `firefox` to support the `helix` editor, but now probably effectively be controlled by `jiff`, which also aligns with `regex`.