Skip to content
This repository was archived by the owner on Jun 3, 2021. It is now read-only.

Conversation

@Ruberto
Copy link
Contributor

@Ruberto Ruberto commented Mar 6, 2017

Hey Everyone,

We are going to be using your API thought that we could easily just help you out getting your ruby wrapper up to date.

This change may induce issues for legacy applications so I would suggest you create a new tag and we / anyone looking at using it in the future can just use an updated version 😄

let me know if you would like to change something with this 👍

@chaselee
Copy link
Contributor

chaselee commented Mar 7, 2017

thanks @Ruberto! I was actually just working on this, so your timing couldn't be better 👍

I'll be doing a full review and checking to make sure everything works correctly, but would you mind making this 2.0.0? I know it's not really proper semver to do so assuming this doesn't introduce backwards-incompatible changes (it might, and I'm fine with that), but given the scope of the changes I think it's the right move to mitigate folks auto-updating to this version.

Let me know if you have any other thoughts and thanks again!

@chaselee chaselee self-requested a review March 7, 2017 16:33
@Ruberto
Copy link
Contributor Author

Ruberto commented Mar 8, 2017

Hey @chaselee, I have bumped the version for you.

Yeah if they have just included the gem as gem 'mbsy' then they will most likely pull 2.0.0 if they bundle update. Unless there is a specific tag that they can add to the Gemfile to point to an older version.

glad to be able to help.

@chaselee chaselee requested a review from brandoshmando March 10, 2017 22:39
Copy link

@brandoshmando brandoshmando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chaselee chaselee merged commit 029e4c8 into GetAmbassador:master Mar 14, 2017
@chaselee
Copy link
Contributor

Thanks again @Ruberto!

@chaselee
Copy link
Contributor

@Ruberto this is available on RubyGems now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants