Skip to content

[BUG] In-progress TV shows not displayed on home page if TV seasons are disabled #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajanvier opened this issue Apr 5, 2025 · 5 comments
Labels
bug Something isn't working fixed in dev Fixed in the development branch

Comments

@ajanvier
Copy link
Contributor

ajanvier commented Apr 5, 2025

Describe the bug
In-progress TV shows are not displayed anymore on the home page since the last Yamtrack version (v0.21.0) if TV seasons are disabled from the sidebar.

To Reproduce
Steps to reproduce the behavior:

  • Have the TV Shows enabled in sidebar but not the TV Seasons (c.f. screenshot)
  • Have some TV shows in progress
  • Go to the home page

Expected behavior
I believe in-progress TV shows should appear on the home page even if we decide to disable TV seasons from the sidebar.

Screenshots
Image

Error logs
N/A

Yamtrack version:
Database: SQLite (default) or PostgreSQL

@ajanvier ajanvier added the bug Something isn't working label Apr 5, 2025
@balgerion
Copy link

Also notification doesn’t work for TV Shows when TV seasons are disabled

@Bobbysx
Copy link

Bobbysx commented Apr 6, 2025

I believe in-progress TV shows should appear on the home page even if we decide to disable TV seasons from the sidebar.

I think it's working the way it's supposed to work. With "TV Seasons" you know what season and what episode you're at (a clunky way, i agree), and it don't repeat "information" showing "TV Shows" tab.

P.S: Separating media types between shows and seasons is a bad strategy in my opinion. But if that's the way the author goes, so be it :)

@FuzzyGrim FuzzyGrim added the fixed in dev Fixed in the development branch label Apr 11, 2025
@FuzzyGrim
Copy link
Owner

The issue from OP has been fixed in the development branch.

Also notification doesn’t work for TV Shows when TV seasons are disabled

I can't replicate this, I think there is another problem with this one. Are you sure the nofitications work when the TV season is enabled but when it is disabled it stops working?

@FuzzyGrim
Copy link
Owner

I understand the confusion around TV Shows vs TV Seasons. I'm thinking of having a better integration between them by removing status fields from the TV Show form and instead having the status determined automatically based on the last seasons' statuses.

What do you think about this direction?

@Bobbysx
Copy link

Bobbysx commented Apr 20, 2025

I don't know who you are asking that question to, but i'll reply since I made a comment about it.

A better integration between them is a good way to go... But sorry, I don't understand what you mean with "having the status determined automatically based on the last seasons' statuses".

  • Removing the TV Seasons tab, and inserting the seasons inside the TV Shows, would be a good strategy (already implemented, i think).
  • All info about seasons and episodes could be displayed in TV Shows (maybe this was what u were referring to)
  • The info could be the next episode not seen (S4xE12), and you could display the episodes seen / episodes available below, like 3/24 or better yet, and progress bar... (Just an idea).

I think I refer all this in an earlier open issue, and i'm sorry if i sound repetitive and/or pushy.. Just trying to give my honest opinion because I really like this project.

But if you go with the direction of having both TV Shows and TV Seasons, don't forget that anime has seasons too (for consistency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Fixed in the development branch
Projects
None yet
Development

No branches or pull requests

4 participants