add refetch releases in sync_metadata()

Author: FuzzyGrim

src/app/models.py

@@ -179,7 +179,7 @@ def generate_manual_id(cls, media_type):
 
         return str(int(latest_item.media_id) + 1)
 
-    def fetch_releases(self):
+    def fetch_releases(self, delay):
         """Fetch releases for the item."""
         if not self._disable_calendar_triggers:
             if self.media_type == MediaTypes.SEASON.value:
@@ -189,8 +189,6 @@ def fetch_releases(self):
                         media_id=self.media_id,
                         source=self.source,
                         media_type=MediaTypes.TV.value,
-                        season_number__isnull=True,
-                        episode_number__isnull=True,
                     )
                 except Item.DoesNotExist:
                     # Get metadata for the TV show
@@ -213,7 +211,10 @@ def fetch_releases(self):
             else:
                 items_to_process = [self]
 
-            events.tasks.reload_calendar.delay(items_to_process=items_to_process)
+            if delay:
+                events.tasks.reload_calendar.delay(items_to_process=items_to_process)
+            else:
+                events.tasks.reload_calendar(items_to_process=items_to_process)
 
 
 class MediaManager(models.Manager):
@@ -768,7 +769,7 @@ def process_status(self):
             if self.tracker.previous("status") == self.Status.REPEATING.value:
                 self.repeats += 1
 
-        self.item.fetch_releases()
+        self.item.fetch_releases(delay=True)
 
     @property
     def formatted_progress(self):
@@ -808,7 +809,7 @@ def save(self, *args, **kwargs):
         if self.tracker.has_changed("status"):
             if self.status == self.Status.COMPLETED.value:
                 self.completed()
-            self.item.fetch_releases()
+            self.item.fetch_releases(delay=True)
 
     @property
     def progress(self):
@@ -992,7 +993,7 @@ def save(self, *args, **kwargs):
                     self.get_remaining_eps(season_metadata),
                     Episode,
                 )
-            self.item.fetch_releases()
+            self.item.fetch_releases(delay=True)
 
     @property
     def progress(self):

src/app/tests/test_views.py

@@ -1430,7 +1430,7 @@ def setUp(self):
 
         # Create some manual TV shows and seasons for testing
         tv_item1 = Item.objects.create(
-            media_id="tv1",
+            media_id="111",
             source=Sources.MANUAL.value,
             media_type=MediaTypes.TV.value,
             title="Test TV Show",
@@ -1442,7 +1442,7 @@ def setUp(self):
         )
 
         tv_item2 = Item.objects.create(
-            media_id="tv2",
+            media_id="222",
             source=Sources.MANUAL.value,
             media_type=MediaTypes.TV.value,
             title="Another TV Show",
@@ -1454,7 +1454,7 @@ def setUp(self):
         )
 
         season_item1 = Item.objects.create(
-            media_id="season1",
+            media_id="111",
             source=Sources.MANUAL.value,
             media_type=MediaTypes.SEASON.value,
             title="Test Season",
@@ -1468,7 +1468,7 @@ def setUp(self):
         )
 
         season_item2 = Item.objects.create(
-            media_id="season2",
+            media_id="222",
             source=Sources.MANUAL.value,
             media_type=MediaTypes.SEASON.value,
             title="Another Season",

src/app/views.py

@@ -303,9 +303,11 @@ def sync_metadata(request, source, media_type, media_id, season_number=None):
 
     ttl = cache.ttl(cache_key)
     logger.debug("%s - Cache TTL for: %s", cache_key, ttl)
-    if ttl is not None and ttl > (settings.CACHE_TIMEOUT - 300):
+
+    if ttl is not None and ttl > (settings.CACHE_TIMEOUT - 30):
         msg = "The data was recently synced, please wait a few minutes."
         messages.error(request, msg)
+        logger.error(msg)
     else:
         deleted = cache.delete(cache_key)
         logger.debug("%s - Old cache deleted: %s", cache_key, deleted)
@@ -316,7 +318,7 @@ def sync_metadata(request, source, media_type, media_id, season_number=None):
             source,
             [season_number],
         )
-        Item.objects.update_or_create(
+        item, _ = Item.objects.update_or_create(
             media_id=media_id,
             source=source,
             media_type=media_type,
@@ -373,14 +375,14 @@ def sync_metadata(request, source, media_type, media_id, season_number=None):
                     ["title", "image"],
                     batch_size=100,
                 )
-
-                # Log results
                 logger.info(
                     "Successfully updated %s episodes for %s",
                     updated_count,
                     title,
                 )
 
+        item.fetch_releases(delay=False)
+
         msg = f"{title} was synced to {Sources(source).label} successfully."
         messages.success(request, msg)
 

src/events/tests/test_calendar.py

@@ -20,6 +20,7 @@
     Season,
     Sources,
 )
+from app.providers import services
 from events.calendar import (
     anilist_date_parser,
     date_parser,
@@ -782,19 +783,20 @@ def test_process_anime_bulk_no_matching_anime(self, mock_api_request):
         # Verify no events were added
         self.assertEqual(len(events_bulk), 0)
 
-    @patch("events.calendar.services.get_media_metadata")
-    def test_http_error_handling(self, mock_get_media_metadata):
-        """Test handling of HTTP errors in process_other."""
-        # Setup mock to raise 404 error
-        import requests
-
+    @patch("app.providers.tmdb.movie")
+    def test_http_error_handling(self, mock_tmdb_movie):
+        """Test handling of ProviderAPIError in process_other."""
+        # Create a mock response for the error
         response_mock = MagicMock()
         response_mock.status_code = 404
-        response_mock.json.return_value = {"error": "Not found"}
+        response_mock.text = "Not found"
 
-        http_error = requests.exceptions.HTTPError("404 Client Error")
-        http_error.response = response_mock
-        mock_get_media_metadata.side_effect = http_error
+        # Create and raise the ProviderAPIError
+        mock_tmdb_movie.side_effect = services.ProviderAPIError(
+            provider=Sources.TMDB.value,
+            error=response_mock,
+            details="Movie not found",
+        )
 
         # Process the item - should not raise exception
         events_bulk = []
@@ -803,15 +805,6 @@ def test_http_error_handling(self, mock_get_media_metadata):
         # Verify no events were added
         self.assertEqual(len(events_bulk), 0)
 
-        # Setup mock to raise 500 error
-        response_mock.status_code = 500
-        http_error = requests.exceptions.HTTPError("500 Server Error")
-        http_error.response = response_mock
-        mock_get_media_metadata.side_effect = http_error
-
-        # Process the item - should raise exception
-        with self.assertRaises(requests.exceptions.HTTPError):
-            process_other(self.movie_item, events_bulk)
 
     @patch("events.calendar.services.get_media_metadata")
     @patch("events.calendar.comicvine.issue")