ci: use extension verifier (#315)

* ci: use extension verifier

* fix: reported errors

Author: shyim

.github/workflows/code-style.yml

@@ -9,9 +9,29 @@ on:
 jobs:
     cs:
         if: github.event_name != 'schedule'
-        uses: shopware/github-actions/.github/workflows/cs-fixer.yml@main
-    phpstan:
-        uses: shopware/github-actions/.github/workflows/phpstan.yml@main
-        with:
-          extensionName: FroshTools
-          shopwareVersion: v6.6.0.0-rc1
+        runs-on: ubuntu-24.04
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v4
+
+            - name: Pull verifier
+              run: docker pull ghcr.io/shopwarelabs/extension-verifier:latest
+
+            - name: Run CS
+              run: docker run --rm -e GITHUB_STEP_SUMMARY -e GITHUB_ACTIONS -v $GITHUB_STEP_SUMMARY:$GITHUB_STEP_SUMMARY -v $(pwd):/ext ghcr.io/shopwarelabs/extension-verifier:latest format /ext --dry-run
+
+    check:
+        runs-on: ubuntu-24.04
+        strategy:
+          fail-fast: false
+          matrix:
+            version-selection: [ 'lowest', 'highest']
+        steps:
+            - name: Checkout
+              uses: actions/checkout@v4
+
+            - name: Pull verifier
+              run: docker pull ghcr.io/shopwarelabs/extension-verifier:latest
+
+            - name: Run Check
+              run: docker run --rm -e GITHUB_STEP_SUMMARY -e GITHUB_ACTIONS -v $GITHUB_STEP_SUMMARY:$GITHUB_STEP_SUMMARY -v $(pwd):/ext ghcr.io/shopwarelabs/extension-verifier:latest check /ext --check-against ${{ matrix.version-selection }}

composer.json

@@ -37,13 +37,16 @@
     "require": {
         "shopware/core": "~6.6.0"
     },
+    "require-dev": {
+        "shopware/elasticsearch": "~6.6.0"
+    },
     "config": {
         "allow-plugins": {
             "symfony/runtime": true
         }
     },
     "scripts": {
-        "cs-fix": "docker run --rm -v $(pwd):$(pwd) -w $(pwd) oskarstark/php-cs-fixer-ga --rules=@PER-CS2.0,no_unused_imports .",
-        "phpstan": "docker run --rm -v $(pwd):/app aragon999/phpstan-shopware:v6.6.0 analyse --level max ."
+        "format": "docker run --rm -v $(pwd):/ext ghcr.io/shopwarelabs/extension-verifier:latest format /ext",
+        "check": "docker run --rm -v $(pwd):/ext ghcr.io/shopwarelabs/extension-verifier:latest check /ext"
     }
 }

phpstan.neon.dist

@@ -2,7 +2,3 @@ parameters:
     level: 8
     paths:
         - src
-    type_coverage:
-        return_type: 100
-        param_type: 98
-        property_type: 100

qodana.yaml

@@ -46,7 +46,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         if ($variable === null) {
             if ($mode === 'json') {
                 $output->writeln(json_encode($file->values(), \JSON_THROW_ON_ERROR | \JSON_PRETTY_PRINT));
-            } elseif ($mode !== '' && $mode !== '0') {
+            } elseif ($mode !== '') {
                 $output->writeln($file->__toString());
             }
 
@@ -60,7 +60,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $var = $file->get($variable);
 
         if (!$var instanceof EnvironmentKeyValue) {
-            throw new \RuntimeException(sprintf('Cannot find variable with name: %s', $variable));
+            throw new \RuntimeException(\sprintf('Cannot find variable with name: %s', $variable));
         }
 
         if ($mode === 'json') {

src/Command/EnvGetCommand.php

@@ -7,4 +7,6 @@
 use Symfony\Component\Console\Attribute\AsCommand;
 
 #[AsCommand('frosh:env:list')]
-class EnvListCommand extends EnvGetCommand {}
+class EnvListCommand extends EnvGetCommand
+{
+}

src/Command/EnvListCommand.php

@@ -45,6 +45,7 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
+        // @phpstan-ignore-next-line
         $context = Context::createDefaultContext();
 
         if ($input->getOption(self::MONITOR_EMAIL_OPTION)) {

src/Command/MonitorCommand.php

@@ -90,7 +90,7 @@ public function clear(): void
                 }
 
                 break;
-            case $this->adapter instanceof AdapterInterface:
+            default:
                 $this->adapter->clear();
 
                 break;
@@ -114,14 +114,15 @@ private function getCacheAdapter(AdapterInterface $adapter): AdapterInterface
     {
         if ($adapter instanceof CacheDecorator) {
             // Do not declare function as static
-            $func = \Closure::bind(fn() => $adapter->decorated, $adapter, $adapter::class);
+            // @phpstan-ignore-next-line
+            $func = \Closure::bind(fn () => $adapter->decorated, $adapter, $adapter::class);
 
             return $this->getCacheAdapter($func());
         }
 
         if ($adapter instanceof TagAwareAdapter || $adapter instanceof TraceableAdapter) {
             // Do not declare function as static
-            $func = \Closure::bind(fn() => $adapter->pool, $adapter, $adapter::class);
+            $func = \Closure::bind(fn () => $adapter->pool, $adapter, $adapter::class);
 
             return $this->getCacheAdapter($func());
         }
@@ -132,25 +133,25 @@ private function getCacheAdapter(AdapterInterface $adapter): AdapterInterface
     private function getRedis(AdapterInterface $adapter): \Redis
     {
         if ($adapter instanceof RedisTagAwareAdapter) {
-            $redisProxyGetter = \Closure::bind(fn() => $adapter->redis, $adapter, RedisTagAwareAdapter::class);
+            $redisProxyGetter = \Closure::bind(fn () => $adapter->redis, $adapter, RedisTagAwareAdapter::class);
         } else {
             // @phpstan-ignore-next-line
-            $redisProxyGetter = \Closure::bind(fn() => $adapter->redis, $adapter, RedisAdapter::class);
+            $redisProxyGetter = \Closure::bind(fn () => $adapter->redis, $adapter, RedisAdapter::class);
         }
 
         return $redisProxyGetter();
     }
 
     private function getPathFromFilesystemAdapter(FilesystemAdapter $adapter): string
     {
-        $getter = \Closure::bind(fn() => $adapter->directory, $adapter, $adapter::class);
+        $getter = \Closure::bind(fn () => $adapter->directory, $adapter, $adapter::class);
 
         return $getter();
     }
 
     private function getPathOfFilesAdapter(PhpFilesAdapter $adapter): string
     {
-        $getter = \Closure::bind(fn() => $adapter->directory, $adapter, $adapter::class);
+        $getter = \Closure::bind(fn () => $adapter->directory, $adapter, $adapter::class);
 
         return $getter();
     }

src/Components/CacheAdapter.php

@@ -31,7 +31,7 @@ public static function removeDir(string $path): void
             $blankDir = sys_get_temp_dir() . '/' . uniqid() . '/';
 
             if (!mkdir($blankDir, 0o755, true) && !is_dir($blankDir)) {
-                throw new \RuntimeException(sprintf('Directory "%s" was not created', $blankDir));
+                throw new \RuntimeException(\sprintf('Directory "%s" was not created', $blankDir));
             }
 
             $process = new Process(['rsync', '-qa', '--delete', $blankDir, $path . '/']);

src/Components/CacheHelper.php

@@ -27,7 +27,7 @@ public function all(): array
     public function get(string $name): CacheAdapter
     {
         if (!isset($this->adapters[$name])) {
-            throw new \OutOfBoundsException(sprintf('Cannot find adapter by name %s', $name));
+            throw new \OutOfBoundsException(\sprintf('Cannot find adapter by name %s', $name));
         }
 
         return $this->adapters[$name];