Merge pull request #151 from FriendsOfREDAXO/copilot/fix-145

Fix InvalidArgumentException when Entry has no author (author_id = 0)

Author: alxndr-w

fragments/neues/entry.php

@@ -27,7 +27,7 @@
                         <?php if (null !== $post->getAuthor()) : ?>
                             <?php if ('' !== $post->getAuthor()->getName()) : ?>
                                 von <span><?= htmlspecialchars($post->getAuthor()->getName()) ?></span>
-                            <?php elseif(null !== $post->getAuthor()->getNickname()): ?>
+                            <?php elseif (null !== $post->getAuthor()->getNickname()): ?>
                                 von <span><?= htmlspecialchars($post->getAuthor()->getNickname()) ?></span>
                             <?php endif ?>
                         <?php endif ?>

fragments/neues/list.php

@@ -14,7 +14,7 @@
 <!-- Entry list -->
 <div class="container">
     <div class="row row-cols-1 row-cols-md-2 g-3">
-        <?php if(0 < count($posts)) { ?>
+        <?php if (0 < count($posts)) { ?>
             <?php foreach ($posts as $post) : ?>
                 <div class="col">
                     <?php
@@ -26,7 +26,7 @@
             <?php endforeach ?>
         <?php } else { ?>
             <div class="placeholder">
-                <?php if(null !== rex_config::get('neues', 'no_entries_placeholder')) { ?>
+                <?php if (null !== rex_config::get('neues', 'no_entries_placeholder')) { ?>
                     <p><?= rex_i18n::msg('no_entries_placeholder') ?></p>
                     <?php } ?>
                 </div>

fragments/neues/pagination.php

@@ -42,7 +42,7 @@
             </li>
 
             <!-- Pages -->
-            <?php for($i = 0; $i < $pager->getPageCount(); ++$i): ?>
+            <?php for ($i = 0; $i < $pager->getPageCount(); ++$i): ?>
                 <li class="page-item">
                     <?php if (0 === $page) : ?>
                         <a class="page-link <?= $currentPage === $i ? 'active' : '' ?>"

install.php

@@ -2,7 +2,6 @@
 
 namespace FriendsOfRedaxo\Neues;
 
-use FriendsOfRedaxo\Neues\Cronjob\Publish;
 use rex;
 use rex_addon;
 use rex_config;

lib/Entry.php

@@ -2,6 +2,7 @@
 
 namespace FriendsOfRedaxo\Neues;
 
+use Alexplusde\ManagerResponsive\Media;
 use IntlDateFormatter;
 use rex_addon;
 use rex_config;
@@ -11,7 +12,6 @@
 use rex_formatter;
 use rex_i18n;
 use rex_media;
-use Alexplusde\ManagerResponsive\Media;
 use rex_url;
 use rex_yform;
 use rex_yform_list;
@@ -177,7 +177,7 @@ static function ($a) {
      */
     public function getAuthor(): ?Author
     {
-        if ($this->hasValue('author_id')) {
+        if ($this->hasValue('author_id') && $this->getValue('author_id') > 0) {
             return Author::get($this->getValue('author_id'));
         }
         return null;

lib/neues.php

@@ -2,7 +2,6 @@
 
 namespace FriendsOfRedaxo\Neues;
 
-use rex;
 use rex_be_controller;
 use rex_be_page;
 use rex_csrf_token;

pages/yform.php

@@ -76,7 +76,6 @@ static function (rex_extension_point $ep) {
 }
 
 if (version_compare(rex_addon::get('yform')->getVersion(), '5.0.0', '<')) {
-
     include rex_path::plugin('yform', 'manager', 'pages/data_edit.php');
 } else {
     include rex_path::addon('yform', 'pages/manager.data_edit.php');