Cleans up Elasticsearch alias handling

Removes unnecessary workaround for Elasticsearch-net issue.
The workaround is no longer needed and simplifies the alias retrieval logic.

Adds a list initialization for clarity.

Author: niemyjski

tests/Foundatio.Repositories.Elasticsearch.Tests/Extensions/ElasticsearchExtensions.cs

@@ -21,10 +21,6 @@ public static async Task AssertSingleIndexAlias(this IElasticClient client, stri
     public static async Task<int> GetAliasIndexCount(this IElasticClient client, string aliasName)
     {
         var response = await client.Indices.GetAliasAsync(aliasName, a => a.IgnoreUnavailable());
-        // TODO: Fix this properly once https://github.com/elastic/elasticsearch-net/issues/3828 is fixed in beta2
-        if (!response.IsValid)
-            return 0;
-
         if (!response.IsValid && response.ServerError?.Status == 404)
             return 0;
 

tests/Foundatio.Repositories.Elasticsearch.Tests/QueryableReadOnlyRepositoryTests.cs

@@ -105,7 +105,8 @@ public async Task SearchByQueryWithIncludesAnAliases()
     [Fact]
     public async Task SearchByAnalyzedTextFieldAsync()
     {
-        await _employeeRepository.AddAsync(new List<Employee> {
+        await _employeeRepository.AddAsync(new List<Employee>
+        {
             EmployeeGenerator.Generate(age: 19, name: "Blake Niemyjski")
         }, o => o.ImmediateConsistency());