Skip to content

Commit cfcfe65

Browse files
jhaleclaude
andauthored
Use wheel.exclude rather than sdist.exclude for wrapper sources (#4428)
sdist.exclude = ["*.cpp"] removed the twelve nanobind wrapper sources from the sdist, not just from the wheel. Since nanobind_add_module() refers to them by name, an sdist built this way cannot be compiled. No sdist has ever been shipped, so nothing already published is affected; this is a latent problem rather than a live one. wheel.exclude keeps the sources out of the wheel, which is what was intended, while leaving the sdist buildable. Verified by building both artefacts: the sdist now carries all twelve dolfinx/wrappers/*.cpp files and the wheel carries none, with the sixteen dolfinx_wrappers/*.h headers present in both as before. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent e100c9c commit cfcfe65

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

python/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ ci = [
8787

8888
[tool.scikit-build]
8989
wheel.packages = ["dolfinx"]
90-
sdist.exclude = ["*.cpp"]
90+
wheel.exclude = ["*.cpp"]
9191
cmake.build-type = "Release"
9292

9393
[tool.scikit-build.cmake.define]

0 commit comments

Comments
 (0)