Respect host and protocol options in vite_preload_tag#413
Merged
ElMassimo merged 2 commits intoElMassimo:mainfrom Nov 5, 2024
Merged
Respect host and protocol options in vite_preload_tag#413ElMassimo merged 2 commits intoElMassimo:mainfrom
ElMassimo merged 2 commits intoElMassimo:mainfrom
Conversation
When specifying the host and protocol options for a vite_javascript_tag we want the preload tags to also respect those options.
ElMassimo
force-pushed
the
main
branch
2 times, most recently
from
d55cc92 to
ebe50b8
Compare
|
Hi @ElMassimo, |
|
Awesome! 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
When specifying the host and protocol options for a
vite_javascript_tag, we want the preload tags to also respect those options.Background 📜
This was causing an issue where the preload tags would not use the CDN specified for the
vite_javascript_tag.