Skip to content

Commit a882ace

Browse files
committed
remove mark_arraybuffer_as_untransferable
This effectively reverts 743db02
1 parent 743db02 commit a882ace

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/js_native_api_v8.cc

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3121,11 +3121,8 @@ napi_create_external_arraybuffer(napi_env env,
31213121
v8::ArrayBuffer::New(isolate, std::move(backing));
31223122

31233123
// https://github.com/nodejs/node/pull/47557 removed the mark_arraybuffer_as_untransferable API
3124-
// do it manually instead
3125-
v8::Maybe<bool> marked = buffer->SetPrivate(env->context(),
3126-
env->node_env()->untransferable_object_private_symbol(),
3127-
v8::True(isolate));
3128-
CHECK_MAYBE_NOTHING(env, marked, napi_generic_failure);
3124+
// v8::Maybe<bool> marked = env->mark_arraybuffer_as_untransferable(buffer);
3125+
// CHECK_MAYBE_NOTHING(env, marked, napi_generic_failure);
31293126

31303127
if (finalize_cb != nullptr) {
31313128
// Create a self-deleting weak reference that invokes the finalizer

0 commit comments

Comments
 (0)