From 6b3f39d816703ae838a8756807d808f20fef303f Mon Sep 17 00:00:00 2001 From: Hotch Date: Thu, 30 Jan 2020 11:07:09 +0000 Subject: [PATCH 1/2] Correct HelpText with examples with work --- src/ExchangeSharpConsole/Options/ExportOption.cs | 4 ++-- src/ExchangeSharpConsole/Options/TradeHistoryOption.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ExchangeSharpConsole/Options/ExportOption.cs b/src/ExchangeSharpConsole/Options/ExportOption.cs index cbfac4b2..316d89d6 100644 --- a/src/ExchangeSharpConsole/Options/ExportOption.cs +++ b/src/ExchangeSharpConsole/Options/ExportOption.cs @@ -13,7 +13,7 @@ namespace ExchangeSharpConsole.Options "This can take a long time depending on your sinceDateTime parameter.\n" + "Please note that not all exchanges will let you do this and may ban your IP if you try to grab to much data at once. " + "I've added sensible sleep statements to limit request rates.\n" + - "Example: export -e gemini --since 20150101 -s btcusd -o \"./data/gemini\"")] + "Example: export -e gemini --since 2015-01-01 -s btcusd -p \"./data/gemini\"")] public class ExportOption : BaseOption, IOptionPerExchange, IOptionPerMarketSymbol, IOptionWithIO, IOptionWithStartDate { @@ -25,7 +25,7 @@ public override Task RunCommand() ExchangeAPI.GetExchangeAPI(ExchangeName), MarketSymbol, Path, - DateTime.Parse(SinceDateString, CultureInfo.InvariantCulture), + DateTime.Parse(SinceDateString, CultureInfo.InvariantCulture).ToUniversalTime(), count => { total = count; diff --git a/src/ExchangeSharpConsole/Options/TradeHistoryOption.cs b/src/ExchangeSharpConsole/Options/TradeHistoryOption.cs index 5cb03eb2..a64f448b 100644 --- a/src/ExchangeSharpConsole/Options/TradeHistoryOption.cs +++ b/src/ExchangeSharpConsole/Options/TradeHistoryOption.cs @@ -8,7 +8,7 @@ namespace ExchangeSharpConsole.Options { [Verb("trade-history", HelpText = "Print trade history from an Exchange to output.\n" + - "Example: trade-history -e Binance -s btcusdt --since \"20180517\" --to \"20180518\"")] + "Example: trade-history -e Binance -s btcusdt --since \"2018-05-17\" --to \"2018-05-18\"")] public class TradeHistoryOption : BaseOption, IOptionPerExchange, IOptionPerMarketSymbol, IOptionWithStartDate, IOptionWithEndDate { From 188ea5bcccdc3e275f98562149a14e22b9147699 Mon Sep 17 00:00:00 2001 From: Hotch Date: Thu, 30 Jan 2020 11:20:33 +0000 Subject: [PATCH 2/2] revert unintended change --- src/ExchangeSharpConsole/Options/ExportOption.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ExchangeSharpConsole/Options/ExportOption.cs b/src/ExchangeSharpConsole/Options/ExportOption.cs index 316d89d6..68752baf 100644 --- a/src/ExchangeSharpConsole/Options/ExportOption.cs +++ b/src/ExchangeSharpConsole/Options/ExportOption.cs @@ -25,7 +25,7 @@ public override Task RunCommand() ExchangeAPI.GetExchangeAPI(ExchangeName), MarketSymbol, Path, - DateTime.Parse(SinceDateString, CultureInfo.InvariantCulture).ToUniversalTime(), + DateTime.Parse(SinceDateString, CultureInfo.InvariantCulture), count => { total = count;