truncate the commit hash inside the c code

Author: tomdaley92

macos/makefile

@@ -6,14 +6,14 @@ ifeq ($(VERSION),)
 VERSION = unknown
 endif
 
-SUB_VERSION := $(if $(GITHUB_SHA),$(shell echo $(GITHUB_SHA) | cut -c1-7),unknown)
+COMMIT_HASH := $(if $(GITHUB_SHA),$(GITHUB_SHA),unknown)
 
 APP_MANIFEST = src/Info.plist
 APP_BUNDLE = $(APP_NAME).app
 APP_EXE = $(APP_NAME)
 
 CC = clang++
-CFLAGS = -std=c++17 -Wall -mmacosx-version-min=11.0 -arch x86_64 -arch arm64 -MMD -MP -DAPP_NAME='"$(APP_NAME)"' -DVERSION='"$(VERSION)"' -DSUB_VERSION='"$(SUB_VERSION)"'
+CFLAGS = -std=c++17 -Wall -mmacosx-version-min=11.0 -arch x86_64 -arch arm64 -MMD -MP -DAPP_NAME='"$(APP_NAME)"' -DVERSION='"$(VERSION)"' -DCOMMIT_HASH='"$(COMMIT_HASH)"'
 LFLAGS = -mmacosx-version-min=11.0
 INCS = -I../external/sdl/build/include/ -I../external/imgui/ -I../shared/
 LIBS = -L../external/sdl/build/lib/ -lSDL2-2.0.0 -framework Cocoa -framework OpenGL
@@ -63,7 +63,7 @@ $(BOOTROM_HEADER): $(BOOTROM_SOURCE)
 
 # Generate Info.plist from template with version substitution
 $(APP_MANIFEST): $(APP_MANIFEST).in
-	sed -e 's/@APP_NAME@/$(APP_NAME)/g' -e 's/@VERSION@/$(VERSION)/g' -e 's/@SUB_VERSION@/$(SUB_VERSION)/g' $< > $@
+	sed -e 's/@APP_NAME@/$(APP_NAME)/g' -e 's/@VERSION@/$(VERSION)/g' -e 's/@COMMIT_HASH@/$(COMMIT_HASH)/g' $< > $@
 
 # Pattern rules for incremental compilation
 %.o: ../shared/%.cc $(LICENSE_HEADER) $(BOOTROM_HEADER)

shared/Chip8.h

@@ -18,10 +18,10 @@
 #define VERSION "unknown"
 #endif
 
-// SUB_VERSION is defined by the compiler via -DSUB_VERSION="..."
+// COMMIT_HASH is defined by the compiler via -DCOMMIT_HASH="..."
 // Falls back to generic name if not defined (shouldn't happen in normal builds)
-#ifndef SUB_VERSION
-#define SUB_VERSION "unknown"
+#ifndef COMMIT_HASH
+#define COMMIT_HASH "unknown"
 #endif
 
 #define MEM_SIZE 4096

shared/Gui.cc

@@ -220,13 +220,18 @@ void Gui::HelpWindows() {
         ImGui::SetNextWindowPosCenter(ImGuiSetCond_Appearing);
         ImGui::Begin("About", &show_about);
 
+        // Truncate COMMIT_HASH to first 7 characters for display
+        char short_hash[8];
+        snprintf(short_hash, sizeof(short_hash), "%.7s", COMMIT_HASH);
+
         ImGui::TextWrapped(
-            APP_NAME " " VERSION " (" SUB_VERSION ")\n"
+            APP_NAME " " VERSION " (%s)\n"
             "\n"
             "A cross-platform Chip-8 interpreter written\n"
             "in C-Style C++ using SDL2, ImGui, and OpenGL.\n"
             "\n"
-            "<https://github.com/Diesel-Net/kiwi-8>\n"
+            "<https://github.com/Diesel-Net/kiwi-8>\n",
+            short_hash
         );
 
         ImGui::End();

windows/makefile

@@ -8,18 +8,17 @@ VERSION = unknown
 !ENDIF
 
 !IFDEF GITHUB_SHA
-# Extract first 7 characters of GITHUB_SHA
-SUB_VERSION = $(GITHUB_SHA:~0,7)
+COMMIT_HASH = $(GITHUB_SHA)
 !ELSE
-SUB_VERSION = unknown
+COMMIT_HASH = unknown
 !ENDIF
 
 APP_EXE = $(APP_NAME).exe
 APP_PDB = $(APP_NAME).pdb
 APP_RES = $(APP_NAME).res
 
 CC = CL
-CFLAGS = /std:c++17 /W4 /MD /nologo /w44996 "/DAPP_NAME=\"$(APP_NAME)\"" "/DVERSION=\"$(VERSION)\"" "/DSUB_VERSION=\"$(SUB_VERSION)\""
+CFLAGS = /std:c++17 /W4 /MD /nologo /w44996 "/DAPP_NAME=\"$(APP_NAME)\"" "/DVERSION=\"$(VERSION)\"" "/DCOMMIT_HASH=\"$(COMMIT_HASH)\""
 LFLAGS = /link \
 		 /LIBPATH:..\external\sdl\build\lib \
 		 /ENTRY:mainCRTStartup