Update linting to forbid System.out/err (#8695)

* Add forbidden System out/errs and suppressmethods

* Add print statement that should fail CI

* Remove print statement

* Adjust test lines

* Extra SuppressForbidden line

* Address missed line number

* Exclude all of smoke-tests

* Fix WeaverTest suppression

* Fix smoke tests suppression

Author: sarahchen6

dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/CrashUploader.java

@@ -121,6 +121,7 @@ public void upload(@Nonnull List<Path> files) throws IOException {
     }
   }
 
+  @SuppressForbidden
   boolean uploadToLogs(@Nonnull Path file) {
     try {
       uploadToLogs(new String(Files.readAllBytes(file), StandardCharsets.UTF_8), System.out);
@@ -156,6 +157,7 @@ void uploadToLogs(@Nonnull String message, @Nonnull PrintStream out) throws IOEx
   }
 
   // @VisibleForTesting
+  @SuppressForbidden
   static String extractErrorKind(String fileContent) {
     Matcher matcher = ERROR_MESSAGE_PATTERN.matcher(fileContent);
     if (!matcher.find()) {

dd-java-agent/agent-logging/src/main/java/datadog/trace/logging/simplelogger/SLCompatSettings.java

@@ -3,6 +3,7 @@
 import datadog.trace.logging.LogLevel;
 import datadog.trace.logging.LogReporter;
 import datadog.trace.logging.PrintStreamWrapper;
+import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.io.File;
 import java.io.FileOutputStream;
 import java.io.IOException;
@@ -169,6 +170,7 @@ public void appendFormattedDate(StringBuilder builder, long timeMillis, long sta
     }
   }
 
+  @SuppressForbidden
   static PrintStream getPrintStream(String logFile) {
     PrintStreamWrapper printStreamWrapper;
     switch (logFile.toLowerCase(Locale.ROOT)) {

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/AgentCLI.java

@@ -9,6 +9,7 @@
 import datadog.trace.bootstrap.InitializationTelemetry;
 import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
 import datadog.trace.bootstrap.instrumentation.api.AgentTracer;
+import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.io.File;
 import java.io.FileOutputStream;
 import java.io.IOException;
@@ -39,6 +40,7 @@ public final class AgentCLI {
   }
 
   /** Prints all known integrations in alphabetical order. */
+  @SuppressForbidden
   public static void printIntegrationNames() {
     Set<String> names = new TreeSet<>();
     for (InstrumenterModule module : InstrumenterIndex.readIndex().modules()) {
@@ -55,6 +57,7 @@ public static void printIntegrationNames() {
    * @param count how many traces to send, negative means send forever
    * @param interval the interval (in seconds) to wait for each trace
    */
+  @SuppressForbidden
   public static void sendSampleTraces(final int count, final double interval) throws Exception {
     Agent.startDatadogTracer(InitializationTelemetry.noOpInstance());
 
@@ -93,6 +96,7 @@ public static void sendOomeEvent(String taglist) throws Exception {
     OOMENotifier.sendOomeEvent(taglist);
   }
 
+  @SuppressForbidden
   public static void scanDependencies(final String[] args) throws Exception {
     Class depClass =
         Class.forName(

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java

@@ -6,6 +6,7 @@
 import datadog.trace.agent.tooling.bytebuddy.SharedTypePools;
 import datadog.trace.agent.tooling.bytebuddy.matcher.ClassLoaderMatchers;
 import datadog.trace.agent.tooling.bytebuddy.matcher.HierarchyMatchers;
+import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -31,6 +32,7 @@ public class MuzzleVersionScanPlugin {
     HierarchyMatchers.registerIfAbsent(HierarchyMatchers.simpleChecks());
   }
 
+  @SuppressForbidden
   public static void assertInstrumentationMuzzled(
       final ClassLoader instrumentationLoader,
       final ClassLoader testApplicationLoader,
@@ -139,6 +141,7 @@ private static Map<String, byte[]> createHelperMap(final InstrumenterModule modu
     return helperMap;
   }
 
+  @SuppressForbidden
   public static void printMuzzleReferences(final ClassLoader instrumentationLoader) {
     for (InstrumenterModule module :
         ServiceLoader.load(InstrumenterModule.class, instrumentationLoader)) {

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/ReferenceCreator.java

@@ -5,6 +5,7 @@
 
 import datadog.trace.agent.tooling.AdviceShader;
 import datadog.trace.bootstrap.Constants;
+import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.io.InputStream;
 import java.util.ArrayDeque;
 import java.util.HashSet;
@@ -47,6 +48,7 @@ public class ReferenceCreator extends ClassVisitor {
    * @return Map of [referenceClassName -> Reference]
    * @throws IllegalStateException if class is not found or unable to be loaded.
    */
+  @SuppressForbidden
   public static Map<String, Reference> createReferencesFrom(
       final String entryPointClassName, final AdviceShader adviceShader, final ClassLoader loader)
       throws IllegalStateException {

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/profiler/EnvironmentChecker.java

@@ -1,6 +1,7 @@
 package datadog.trace.agent.tooling.profiler;
 
 import datadog.trace.api.Platform;
+import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.io.File;
 import java.io.IOException;
 import java.net.URL;
@@ -16,6 +17,7 @@
 import java.util.jar.JarFile;
 
 public final class EnvironmentChecker {
+  @SuppressForbidden
   public static boolean checkEnvironment(String temp) {
     if (!Platform.isJavaVersionAtLeast(8)) {
       System.out.println("Profiler requires Java 8 or newer");
@@ -52,6 +54,7 @@ public static boolean checkEnvironment(String temp) {
     return true;
   }
 
+  @SuppressForbidden
   private static boolean checkJFR() {
     if (Platform.isOracleJDK8()) {
       System.out.println(
@@ -66,6 +69,7 @@ private static boolean checkJFR() {
     }
   }
 
+  @SuppressForbidden
   private static boolean checkDdprof() {
     if (!Platform.isLinux()) {
       System.out.println("Datadog profiler is only supported on Linux.");
@@ -76,6 +80,7 @@ private static boolean checkDdprof() {
     }
   }
 
+  @SuppressForbidden
   private static boolean checkTempLocation(String temp) {
     // Check if the temp directory is writable
     if (temp == null || temp.isEmpty()) {
@@ -161,6 +166,7 @@ public FileVisitResult postVisitDirectory(Path dir, IOException exc)
     return rslt;
   }
 
+  @SuppressForbidden
   private static boolean checkCreateTempFile(Path target) {
     // create a file to check if the directory is writable
     try {
@@ -176,6 +182,7 @@ private static boolean checkCreateTempFile(Path target) {
     return false;
   }
 
+  @SuppressForbidden
   private static boolean checkLoadLibrary(Path target) {
     if (!Platform.isLinux()) {
       // we are loading the native library only on linux
@@ -199,6 +206,7 @@ private static boolean checkLoadLibrary(Path target) {
     }
   }
 
+  @SuppressForbidden
   private static boolean extractSoFromJar(Path target) throws Exception {
     URL jarUrl = EnvironmentChecker.class.getProtectionDomain().getCodeSource().getLocation();
     try (JarFile jarFile = new JarFile(new File(jarUrl.toURI()))) {

dd-java-agent/instrumentation-annotation-processor/src/main/java/datadog/apt/ByteBuddyAdviceProcessor.java

@@ -4,6 +4,7 @@
 import static datadog.apt.LogUtils.*;
 import static datadog.apt.TypeUtils.*;
 
+import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.util.Set;
 import javax.annotation.processing.AbstractProcessor;
 import javax.annotation.processing.RoundEnvironment;
@@ -30,6 +31,7 @@ public SourceVersion getSupportedSourceVersion() {
   }
 
   @Override
+  @SuppressForbidden
   public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
     try {
       processImpl(annotations, roundEnv);

dd-java-agent/instrumentation/weaver/src/main/scala/datadog/trace/instrumentation/weaver/WeaverIntegrationTestRunner.scala

@@ -8,6 +8,7 @@ import java.io.PrintStream
 import scala.jdk.CollectionConverters.*
 
 object WeaverIntegrationTestRunner {
+  @de.thetaphi.forbiddenapis.SuppressForbidden
   def runTests(testNames: java.util.List[String]): Unit = {
     class WeaverTestEventHandler() extends EventHandler {
       val events = scala.collection.mutable.ListBuffer.empty[sbt.testing.Event]

dd-java-agent/load-generator/src/main/java/datadog/loadgenerator/LoadGenerator.java

@@ -1,6 +1,7 @@
 package datadog.loadgenerator;
 
 import com.google.common.util.concurrent.RateLimiter;
+import de.thetaphi.forbiddenapis.SuppressForbidden;
 import io.opentracing.Scope;
 import io.opentracing.Span;
 import io.opentracing.Tracer;
@@ -53,6 +54,7 @@ public class LoadGenerator implements Callable<Integer> {
   private final AtomicLong tracesSent = new AtomicLong();
 
   @Override
+  @SuppressForbidden
   public Integer call() throws Exception {
     rateLimiter = RateLimiter.create(rate, warmupPeriod, TimeUnit.SECONDS);
 

dd-java-agent/src/main/java/datadog/trace/bootstrap/AgentBootstrap.java

@@ -59,6 +59,7 @@ public static void premain(final String agentArgs, final Instrumentation inst) {
     agentmain(agentArgs, inst);
   }
 
+  @SuppressForbidden
   public static void agentmain(final String agentArgs, final Instrumentation inst) {
     BootstrapInitializationTelemetry initTelemetry;
 
@@ -181,6 +182,7 @@ static boolean exceptionCauseChainContains(Throwable ex, String exClassName) {
     return false;
   }
 
+  @SuppressForbidden
   private static boolean alreadyInitialized() {
     if (initialized) {
       System.err.println(
@@ -191,6 +193,7 @@ private static boolean alreadyInitialized() {
     return false;
   }
 
+  @SuppressForbidden
   private static boolean lessThanJava8() {
     try {
       return lessThanJava8(System.getProperty("java.version"), System.err);
@@ -286,6 +289,7 @@ static int parseJavaMajorVersion(String version) {
     return major;
   }
 
+  @SuppressForbidden
   static boolean shouldAbortDueToOtherJavaAgents() {
     // Simply considering having multiple agents
 
@@ -322,6 +326,7 @@ public static void main(final String[] args) {
     AgentJar.main(args);
   }
 
+  @SuppressForbidden
   private static synchronized URL installAgentJar(final Instrumentation inst)
       throws IOException, URISyntaxException {
     // First try Code Source
@@ -364,6 +369,7 @@ private static URL appendAgentToBootstrapClassLoaderSearch(
     return ddJavaAgentJarURL;
   }
 
+  @SuppressForbidden
   private static File getAgentFileFromJavaagentArg(List<File> agentFiles) {
     if (agentFiles.isEmpty()) {
       System.err.println("Could not get bootstrap jar from -javaagent arg: no argument specified");
@@ -377,6 +383,7 @@ private static File getAgentFileFromJavaagentArg(List<File> agentFiles) {
     }
   }
 
+  @SuppressForbidden
   private static List<File> getAgentFilesFromVMArguments() {
     if (agentFiles == null) {
       agentFiles = new ArrayList<>();