the $ support added for DuckDB does not need to exacerbate the OLEDB problem (#1979)

Author: mgravell

Dapper/SqlMapper.cs

@@ -2387,7 +2387,7 @@ private static IEnumerable<PropertyInfo> FilterParameters(IEnumerable<PropertyIn
         }
 
         // look for ? / @ / : *by itself*
-        private static readonly Regex smellsLikeOleDb = new(@"(?<![\p{L}\p{N}@_])[?@:$](?![\p{L}\p{N}@_])", RegexOptions.IgnoreCase | RegexOptions.Multiline | RegexOptions.CultureInvariant | RegexOptions.Compiled),
+        private static readonly Regex smellsLikeOleDb = new(@"(?<![\p{L}\p{N}@_])[?@:](?![\p{L}\p{N}@_])", RegexOptions.IgnoreCase | RegexOptions.Multiline | RegexOptions.CultureInvariant | RegexOptions.Compiled),
             literalTokens = new(@"(?<![\p{L}\p{N}_])\{=([\p{L}\p{N}_]+)\}", RegexOptions.IgnoreCase | RegexOptions.Multiline | RegexOptions.CultureInvariant | RegexOptions.Compiled),
             pseudoPositional = new(@"\?([\p{L}_][\p{L}\p{N}_]*)\?", RegexOptions.IgnoreCase | RegexOptions.CultureInvariant | RegexOptions.Compiled);
 

docs/index.md

@@ -26,6 +26,7 @@ Note: to get the latest pre-release build, add ` -Pre` to the end of the command
 
 - infer command text without any whitespace as stored-procedure (#1975 via @mgravell)
 - add global `SupportLegacyParameterTokens` setting to enable or disable single-character parameter tokens (#1974 via @Giorgi)
+- revert `$` addition for legacy parameter tokens (#1979 via @mgravell)
 
 ### 2.1.4