Improve scrolling and navigation with keyboard in palette

SamyPesse · SamyPesse · commit d3042c40e27e · 2014-03-23T00:09:54.000-07:00
diff --git a/client/views/commands/palette.js b/client/views/commands/palette.js
@@ -210,8 +210,10 @@ templateFile, commandTemplateFile) {
                     h = item.$el.outerHeight();
                     y = item.$el.position().top;
 
-                    if (y > (boxH-(h/2)) || y < 0) {
+                    if (y > (boxH-(h/2))) {
                         this.$(".results").scrollTop((i+1)*h - boxH)
+                    } else if (y <= (h/2)) {
+                        this.$(".results").scrollTop((i)*h)
                     }
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -210,8 +210,10 @@ templateFile, commandTemplateFile) {`
`210`	`210`	`h = item.$el.outerHeight();`
`211`	`211`	`y = item.$el.position().top;`
`212`	`212`
`213`		`- if (y > (boxH-(h/2)) \|\| y < 0) {`
	`213`	`+ if (y > (boxH-(h/2))) {`
`214`	`214`	`this.$(".results").scrollTop((i+1)*h - boxH)`
	`215`	`+ } else if (y <= (h/2)) {`
	`216`	`+ this.$(".results").scrollTop((i)*h)`
`215`	`217`	`}`
`216`	`218`	`}`
`217`	`219`