Skip to content

Commit 367ee1c

Browse files
committed
Clean up useless code and add comments
1 parent 5ed6842 commit 367ee1c

File tree

4 files changed

+16
-19
lines changed

4 files changed

+16
-19
lines changed

CodeEdit/Breadcrumbs/BreadcrumbsComponent.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ struct BreadcrumbsComponent: View {
3030
Text(title)
3131
.foregroundStyle(.primary)
3232
.font(.system(size: 11))
33-
.lineLimit(1)
34-
.truncationMode(.middle)
3533
}
3634
}
3735
}

CodeEdit/Breadcrumbs/BreadcrumbsMenu.swift

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,19 @@ import SwiftUI
99
import WorkspaceClient
1010

1111
struct BreadcrumbsMenu: View {
12+
/// The current `WorkspaceDocument`
1213
@ObservedObject var workspace: WorkspaceDocument
14+
15+
/// The parent of `FileItem` for this view
1316
private var parentFileItem: WorkspaceClient.FileItem?
17+
18+
/// File name
1419
private let title: String
20+
21+
/// File icon
1522
private let image: String
23+
24+
/// File icon's color
1625
private let color: Color
1726

1827
init(

CodeEdit/Breadcrumbs/BreadcrumbsMenuItem.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ import SwiftUI
99
import WorkspaceClient
1010

1111
struct BreadcrumbsMenuItem: View {
12+
/// Current `WorkspaceDocument`
1213
@ObservedObject var workspace: WorkspaceDocument
14+
15+
/// The `FileItem` for this view
1316
var fileItem: WorkspaceClient.FileItem
14-
@State var shouldLoadChildren: Bool = false
1517

1618
var body: some View {
1719
if let children = fileItem.children?.sortItems(foldersOnTop: true), !children.isEmpty {

CodeEdit/Breadcrumbs/BreadcrumbsView.swift

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,7 @@ struct BreadcrumbsView: View {
1212

1313
@ObservedObject var workspace: WorkspaceDocument
1414
let file: WorkspaceClient.FileItem
15-
16-
@State private var projectName: String = ""
1715
@State private var fileItems: [WorkspaceClient.FileItem] = []
18-
@State private var folders: [String] = []
19-
@State private var fileName: String = ""
20-
@State private var fileImage: String = "doc"
2116

2217
init(_ file: WorkspaceClient.FileItem, workspace: WorkspaceDocument) {
2318
self.file = file
@@ -34,6 +29,9 @@ struct BreadcrumbsView: View {
3429
if fileItem.parent != nil {
3530
chevron
3631
}
32+
/// If current fileItem has no parent, it's the workspace root directory
33+
/// else if current fileItem has no children, it's the opened file
34+
/// else it's a folder
3735
let color = fileItem.parent == nil
3836
? .accentColor
3937
: fileItem.children?.isEmpty ?? true
@@ -72,21 +70,11 @@ struct BreadcrumbsView: View {
7270
private func fileInfo(_ file: WorkspaceClient.FileItem) {
7371
self.fileItems = []
7472
var currentFile: WorkspaceClient.FileItem? = file
73+
/// Traverse from bottom to top until `currentFile` has no parent.
7574
while currentFile != nil {
7675
self.fileItems.insert(currentFile!, at: 0)
7776
currentFile = currentFile!.parent
7877
}
79-
guard let projURL = workspace.fileURL else { return }
80-
let components = file.url.path
81-
.replacingOccurrences(of: projURL.path, with: "")
82-
.split(separator: "/")
83-
.map { String($0) }
84-
.dropLast()
85-
86-
self.projectName = projURL.lastPathComponent
87-
self.folders = Array(components)
88-
self.fileName = file.fileName
89-
self.fileImage = file.systemImage
9078
}
9179
}
9280

0 commit comments

Comments
 (0)