Fix Tasks Not Saving (#2034)

### Description

Fixes a bug where tasks would not save after creating them due to an accidental change when removing a deprecated URL method. Also removes a few unnecessary view models in settings, and correctly handles errors thrown when saving workspace settings in UI (with a simple alert).

### Related Issues

* N/A Reported on [discord](https://discord.com/channels/951544472238444645/952640521812193411/1362011473324540097)

### Checklist

- [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

Author: thecoolwinter

CodeEdit/Features/CEWorkspaceSettings/Models/CEWorkspaceSettings.swift

@@ -17,8 +17,8 @@ final class CEWorkspaceSettings: ObservableObject {
 
     private(set) var folderURL: URL
 
-    private var settingsURL: URL {
-        folderURL.appending(path: "settings").appending(path: "json")
+    var settingsURL: URL {
+        folderURL.appending(path: "settings").appendingPathExtension("json")
     }
 
     init(workspaceURL: URL) {
@@ -54,7 +54,17 @@ final class CEWorkspaceSettings: ObservableObject {
     /// Save``CEWorkspaceSettingsManager`` model to `.codeedit/settings.json`
     func savePreferences() throws {
         // If the user doesn't have any settings to save, don't save them.
-        guard !settings.isEmpty() else { return }
+        guard !settings.isEmpty() else {
+            // Settings is empty, remove the file & directory if it's empty.
+            if fileManager.fileExists(atPath: settingsURL.path()) {
+                try fileManager.removeItem(at: settingsURL)
+
+                if try fileManager.contentsOfDirectory(atPath: folderURL.path()).isEmpty {
+                    try fileManager.removeItem(at: folderURL)
+                }
+            }
+            return
+        }
 
         if !fileManager.fileExists(atPath: folderURL.path()) {
             try fileManager.createDirectory(at: folderURL, withIntermediateDirectories: true)

CodeEdit/Features/CEWorkspaceSettings/Views/CETaskFormView.swift

@@ -12,7 +12,6 @@ struct CETaskFormView: View {
     @ObservedObject var task: CETask
     @State private var selectedEnvID: UUID?
 
-    @StateObject var settingsViewModel = SettingsViewModel()
     var body: some View {
         Form {
             Section {
@@ -85,7 +84,6 @@ struct CETaskFormView: View {
             }
         }
         .formStyle(.grouped)
-        .environmentObject(settingsViewModel)
     }
 
     func removeSelectedEnv() {
@@ -100,7 +98,3 @@ struct CETaskFormView: View {
         })
     }
 }
-
-// #Preview {
-//    CETaskFormView()
-// }

CodeEdit/Features/CEWorkspaceSettings/Views/CEWorkspaceSettingsView.swift

@@ -13,8 +13,6 @@ struct CEWorkspaceSettingsView: View {
     @EnvironmentObject var workspaceSettingsManager: CEWorkspaceSettings
     @EnvironmentObject var workspace: WorkspaceDocument
 
-    @StateObject var settingsViewModel = SettingsViewModel()
-
     @State var selectedTaskID: UUID?
     @State var showAddTaskSheet: Bool = false
 
@@ -68,7 +66,6 @@ struct CEWorkspaceSettingsView: View {
             }
             .padding()
         }
-        .environmentObject(settingsViewModel)
         .sheet(isPresented: $showAddTaskSheet) {
             if let selectedTaskIndex = workspaceSettingsManager.settings.tasks.firstIndex(where: {
                 $0.id == selectedTaskID

CodeEdit/Features/CEWorkspaceSettings/Views/EditCETaskView.swift

@@ -23,12 +23,16 @@ struct EditCETaskView: View {
             Divider()
             HStack {
                 Button(role: .destructive) {
-                    workspaceSettingsManager.settings.tasks.removeAll(where: {
-                        $0.id == task.id
-                    })
-                    try? workspaceSettingsManager.savePreferences()
-                    taskManager.deleteTask(taskID: task.id)
-                    self.dismiss()
+                    do {
+                        workspaceSettingsManager.settings.tasks.removeAll(where: {
+                            $0.id == task.id
+                        })
+                        try workspaceSettingsManager.savePreferences()
+                        taskManager.deleteTask(taskID: task.id)
+                        self.dismiss()
+                    } catch {
+                        NSAlert(error: error).runModal()
+                    }
                 } label: {
                     Text("Delete")
                         .foregroundStyle(.red)
@@ -38,8 +42,12 @@ struct EditCETaskView: View {
                 Spacer()
 
                 Button {
-                    try? workspaceSettingsManager.savePreferences()
-                    self.dismiss()
+                    do {
+                        try workspaceSettingsManager.savePreferences()
+                        self.dismiss()
+                    } catch {
+                        NSAlert(error: error).runModal()
+                    }
                 } label: {
                     Text("Done")
                         .frame(minWidth: 56)

CodeEditTests/Features/WorkspaceSettings/CEWorkspaceSettingsTests.swift

@@ -0,0 +1,20 @@
+//
+//  CEWorkspaceSettingsTests.swift
+//  CodeEditTests
+//
+//  Created by Khan Winter on 4/21/25.
+//
+
+import Foundation
+import Testing
+@testable import CodeEdit
+
+struct CEWorkspaceSettingsTests {
+    let settings: CEWorkspaceSettings = CEWorkspaceSettings(workspaceURL: URL(filePath: "/"))
+
+    @Test
+    func settingsURLNoSpace() async throws {
+        #expect(settings.folderURL.lastPathComponent == ".codeedit")
+        #expect(settings.settingsURL.lastPathComponent == "settings.json")
+    }
+}