Specify types for Provider query parameters #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Conclusively specify types for query parameters
zaksoup
requested review from
a team,
hunterowens and
thekaveman
as code owners
thekaveman
approved these changes
Aug 15, 2019
Collaborator
thekaveman
left a comment
thekaveman
left a comment
There was a problem hiding this comment.
Good clarification, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Hi, I'm Zak and I joined the team at Remix a few weeks ago. I'm excited to work with the MDS community!
Explanation
In MDS Provider it is implied that all references to timestamps should be made using
milliseconds since unix epoch. The sections of the providerREADMEfor query parameters do not explicitly state types for query parameters. This change formats the explanations of query parameters to match the table specification for returned data and explicitly set types for each parameter.Is this a breaking change
Providers who assumed the query parameter types were ambiguous may have to update their code if they were using
seconds since unix epochinstead ofmillisconds.Provideroragency?Provider.