[ENG-8193] Fix issues with Preprint submission via API #11185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
requested changes
Jun 18, 2025
There was a problem hiding this comment.
Could you unit test this and verify that the situation in the ticket raises a 400 error rather than having an uncaught exception? Also, is every exception at this point going to be a DjangoValidationError, or are there any other errors possible at this point, like Conflicts or JSONAPIAttributeExceptions?
|
Any raised exceptions from rest_framework.exceptions (like Conflict, NotFound, ValidationError, etc.) are going to be handled by DRF and return appropriate status code. I've added unit tests to test 400 and 409, also added handling for ValueError. All other exceptions are not expected here I think, so they should return 500 JSONAPIAttributeExceptions and similar are going to be handled by our custom exception handler |
brianjgeiger
approved these changes
Jun 20, 2025
brianjgeiger
changed the base branch from
feature/pbs-25-10
to
feature/pbs-25-13
brianjgeiger
merged commit 9aa22ee
into
CenterForOpenScience:feature/pbs-25-13
6 checks passed
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Jul 16, 2025
…cience/osf.io into add-brand-to-collection-provider * 'feature/pbs-25-13' of https://github.com/CenterForOpenScience/osf.io: (25 commits) [ENG-8224] Fixed force archive template with registration addons (CenterForOpenScience#11210) API: Allow /v2/users/me/preprints list view to filter by title [ENG-8325] Public column does not display the visibility status of child nodes on the Nodes page in the Admin App [ENG-8246] Fixed deletion of maintenance alerts in admin (CenterForOpenScience#11226) add exception handling to /review_actions/ endpoint added a route to download node metadata (CenterForOpenScience#11215) [ENG-7929] Ability to move registrations to draft state (CenterForOpenScience#11153) switch to new UI when user views draft registration file (CenterForOpenScience#11144) [ENG-5862] SPAM - Fix Wiki Spamming (CenterForOpenScience#11171) improved displaying of stashed urls and approval state in admin (CenterForOpenScience#11193) [ENG-7962] Fix User Setting Response Payload async mailchimp perference change issues (CenterForOpenScience#11136) fixed children/parent fields in admin templates (CenterForOpenScience#11156) don't add multiple group perms for preprint provider (CenterForOpenScience#11159) fix content overflow for node page (CenterForOpenScience#11182) [ENG-8096] Admins on projects are unable to reject user access requests (CenterForOpenScience#11163) added retry to avoid race condition (CenterForOpenScience#11179) upgrade django to 4.2.17 (CenterForOpenScience#11173) add additional information to user admin (CenterForOpenScience#11184) [ENG-8192] Ability to force archive registrations when OSFS Folders have changed (CenterForOpenScience#11194) [ENG-8193] Fix issues with Preprint submission via API (CenterForOpenScience#11185) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
handle django core ValidationError in drf view
Changes
QA Notes
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8193