update tests

Author: John Tordoff

osf_tests/management_commands/test_withdraw_all_preprints_from_provider.py

@@ -2,6 +2,8 @@
 
 from osf.management.commands.withdraw_all_preprints_from_provider import withdraw_all_preprints
 from osf_tests.factories import PreprintProviderFactory, PreprintFactory, AuthUserFactory
+from tests.utils import capture_notifications
+
 
 @pytest.mark.django_db
 class TestWithdrawAllPreprint:
@@ -23,7 +25,8 @@ def withdrawing_user(self):
         return AuthUserFactory()
 
     def test_withdraw_all_preprints(self, preprint_provider, provider_preprint, withdrawing_user):
-        withdraw_all_preprints(preprint_provider._id, 10, withdrawing_user._id, 'test_comment')
+        with capture_notifications():
+            withdraw_all_preprints(preprint_provider._id, 10, withdrawing_user._id, 'test_comment')
         provider_preprint.reload()
 
         assert provider_preprint.is_retracted

osf_tests/metadata/test_osf_gathering.py

@@ -29,6 +29,7 @@
 from osf.metrics.utils import YearMonth
 from osf.utils import permissions, workflows
 from osf_tests import factories
+from tests.utils import capture_notifications
 from website import settings as website_settings
 from website.project import new_bookmark_collection
 from osf_tests.metadata._utils import assert_triples
@@ -562,8 +563,9 @@ def test_gather_affiliated_institutions(self):
         institution = factories.InstitutionFactory()
         institution_iri = URIRef(institution.ror_uri)
         self.user__admin.add_or_update_affiliated_institution(institution)
-        self.project.add_affiliated_institution(institution, self.user__admin)
-        self.preprint.add_affiliated_institution(institution, self.user__admin)
+        with capture_notifications():
+            self.project.add_affiliated_institution(institution, self.user__admin)
+            self.preprint.add_affiliated_institution(institution, self.user__admin)
         assert_triples(osf_gathering.gather_affiliated_institutions(self.projectfocus), {
             (self.projectfocus.iri, OSF.affiliation, institution_iri),
             (institution_iri, RDF.type, DCTERMS.Agent),
@@ -693,11 +695,12 @@ def test_gather_collection_membership(self):
             reviews_workflow='post-moderation',
         )
         _collection = factories.CollectionFactory(provider=_collection_provider)
-        osfdb.CollectionSubmission.objects.create(
-            guid=self.project.guids.first(),
-            collection=_collection,
-            creator=self.project.creator,
-        )
+        with capture_notifications():
+            osfdb.CollectionSubmission.objects.create(
+                guid=self.project.guids.first(),
+                collection=_collection,
+                creator=self.project.creator,
+            )
         _collection_ref = rdflib.URIRef(
             f'{website_settings.DOMAIN}collections/{_collection_provider._id}',
         )

osf_tests/test_elastic_search.py

@@ -292,7 +292,8 @@ def test_collection_submission_doc_structure(self):
         assert docs[0]['_source']['category'] == 'collectionSubmission'
 
     def test_search_updated_after_id_change(self):
-        self.provider.primary_collection.collect_object(self.node_one, self.node_one.creator)
+        with capture_notifications():
+            self.provider.primary_collection.collect_object(self.node_one, self.node_one.creator)
         with run_celery_tasks():
             self.node_one.save()
         term = f'provider:{self.provider._id}'
@@ -501,7 +502,8 @@ def test_unsubmitted_preprint_primary_file(self):
     def test_publish_preprint(self):
         title = 'Date'
         self.preprint = factories.PreprintFactory(creator=self.user, is_published=False, title=title)
-        self.preprint.set_published(True, auth=Auth(self.preprint.creator), save=True)
+        with capture_notifications():
+            self.preprint.set_published(True, auth=Auth(self.preprint.creator), save=True)
         assert self.preprint.title == title
         docs = query(title)['results']
         # Both preprint and primary_file showing up in Elastic
@@ -1344,7 +1346,9 @@ def test_migration_collections(self):
         collection_one = factories.CollectionFactory(is_public=True, provider=provider)
         collection_two = factories.CollectionFactory(is_public=True, provider=provider)
         node = factories.NodeFactory(creator=self.user, title='Ali Bomaye', is_public=True)
-        collection_one.collect_object(node, self.user)
+
+        with capture_notifications():
+            collection_one.collect_object(node, self.user)
         collection_two.collect_object(node, self.user)
         assert node.collection_submissions.filter(
             machine_state=CollectionSubmissionStates.ACCEPTED

osf_tests/test_guid.py

@@ -20,6 +20,7 @@
 )
 from tests.base import OsfTestCase
 from tests.test_websitefiles import TestFile
+from tests.utils import capture_notifications
 from website.settings import MFR_SERVER_URL, WATERBUTLER_URL
 
 
@@ -312,7 +313,8 @@ def test_resolve_guid_download_file_from_emberapp_preprints_unpublished(self):
         # test_provider_submitter_can_download_unpublished
         submitter = AuthUserFactory()
         pp = PreprintFactory(finish=True, provider=provider, is_published=False, creator=submitter)
-        pp.run_submit(submitter)
+        with capture_notifications():
+            pp.run_submit(submitter)
         pp_branded = PreprintFactory(finish=True, provider=branded_provider, is_published=False, filename='preprint_file_two.txt', creator=submitter)
         pp_branded.run_submit(submitter)