Skip to content

Commit 6831189

Browse files
authored
Don't default construct ModelConfig when default constructing VllmConfig (vllm-project#17943)
Signed-off-by: Harry Mellor <[email protected]>
1 parent fc4441a commit 6831189

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

vllm/config.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3954,7 +3954,9 @@ class VllmConfig:
39543954
simplifies passing around the distinct configurations in the codebase.
39553955
"""
39563956

3957-
model_config: ModelConfig = field(default_factory=ModelConfig)
3957+
# TODO: use default_factory once default constructing ModelConfig doesn't
3958+
# try to download a model
3959+
model_config: ModelConfig = None # type: ignore
39583960
"""Model configuration."""
39593961
cache_config: CacheConfig = field(default_factory=CacheConfig)
39603962
"""Cache configuration."""

0 commit comments

Comments
 (0)