Skip to content

fix: StaticArrayVal payload encoding, improve roundtrip checker #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

aborgna-q
Copy link
Collaborator

The eager encoding of StaticArrayVal's payload caused the nested values to be encoded as escaped strings, causing errors on the rust decoder.

This PR rollbacks the changes to StaticArrayVal done in #2436 and adds a better workaround in the roundtrip test instead.

@aborgna-q aborgna-q requested a review from ss2165 July 16, 2025 15:20
@aborgna-q aborgna-q requested a review from a team as a code owner July 16, 2025 15:20
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.03%. Comparing base (ce5a763) to head (e62f3ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2444   +/-   ##
=======================================
  Coverage   82.03%   82.03%           
=======================================
  Files         247      247           
  Lines       46018    46018           
  Branches    41608    41608           
=======================================
  Hits        37749    37749           
  Misses       6250     6250           
  Partials     2019     2019           
Flag Coverage Δ
python 85.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aborgna-q aborgna-q added this pull request to the merge queue Jul 16, 2025
Merged via the queue into main with commit 1a301eb Jul 16, 2025
25 checks passed
@aborgna-q aborgna-q deleted the ab/fix-array-val-encoding branch July 16, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants