fix: Don't enable envelope compression by default (yet) #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2014 +/- ##
==========================================
- Coverage 83.83% 83.83% -0.01%
==========================================
Files 210 210
Lines 39640 39640
Branches 36312 36312
==========================================
- Hits 33234 33231 -3
- Misses 4530 4533 +3
Partials 1876 1876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jake-arkinstall
approved these changes
Mar 21, 2025
croyzor
approved these changes
Mar 21, 2025
This was referenced Mar 21, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
## 🤖 New release * `hugr-core`: 0.15.1 -> 0.15.2 (✓ API compatible changes) * `hugr-llvm`: 0.15.1 -> 0.15.2 * `hugr-passes`: 0.15.1 -> 0.15.2 * `hugr`: 0.15.1 -> 0.15.2 (✓ API compatible changes) * `hugr-cli`: 0.15.1 -> 0.15.2 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr-core` <blockquote> ## [0.15.2](hugr-core-v0.15.1...hugr-core-v0.15.2) - 2025-03-21 ### Bug Fixes - Don't enable envelope compression by default (yet) ([#2014](#2014)) - Inconsistent behaviour in `SiblingSubgraph::from_nodes` ([#2011](#2011)) </blockquote> ## `hugr-llvm` <blockquote> ## [0.15.1](hugr-llvm-v0.15.0...hugr-llvm-v0.15.1) - 2025-03-21 ### Bug Fixes - Remove return from val_or_panic ([#1999](#1999)) ### New Features - add exit operation to prelude ([#2008](#2008)) - Add llvm codegen for collections.static_array ([#2003](#2003)) </blockquote> ## `hugr-passes` <blockquote> ## [0.15.1](hugr-passes-v0.15.0...hugr-passes-v0.15.1) - 2025-03-21 ### Bug Fixes - correct `CallIndirect` tag from `FnCall` to `DataflowChild` ([#2006](#2006)) </blockquote> ## `hugr` <blockquote> ## [0.15.2](hugr-v0.15.1...hugr-v0.15.2) - 2025-03-21 ### Bug Fixes - Don't enable envelope compression by default (yet) ([#2014](#2014)) - Inconsistent behaviour in `SiblingSubgraph::from_nodes` ([#2011](#2011)) </blockquote> ## `hugr-cli` <blockquote> ## [0.15.1](hugr-cli-v0.15.0...hugr-cli-v0.15.1) - 2025-03-21 ### New Features - *(hugr-cli)* Nicer error when passing a non-envelope file ([#2007](#2007)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
🤖 I have created a release *beep* *boop* --- ## [0.11.3](hugr-py-v0.11.2...hugr-py-v0.11.3) (2025-03-21) ### Bug Fixes * Don't enable envelope compression by default (yet) ([#2014](#2014)) ([c5423ed](c5423ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did a hugr-rs minor release changing the default binary envelope encoding to have compression enabled.
Since compression support was added in the same minor match, previous semver-compatible releases will fail to read such envelopes.
This PR disables default compression. We should enable it on the next breaking release instead.