++

Author: Damir Zainullin

src/plugins/process/tcpRtt/src/tcpRtt.hpp

@@ -10,9 +10,9 @@
 
 #pragma once
 
-#include <sstream>
 #include <limits>
 #include <memory>
+#include <sstream>
 
 #include <ipfixprobe/flowifc.hpp>
 #include <ipfixprobe/ipfix-basiclist.hpp>
@@ -34,45 +34,45 @@ UR_FIELDS(uint64 TCPRTT_TIME)
  * @param timeval Timeval to convert
  * @return Count of milliseconds since epoch
  */
-constexpr static inline
-uint64_t timeval_to_msec(timeval timeval) noexcept
+constexpr static inline uint64_t timeval_to_msec(timeval timeval) noexcept
 {
-    constexpr size_t MSEC_IN_SEC = 1'000;
-    constexpr size_t USEC_IN_MSEC = 1'000;
-    return timeval.tv_sec * MSEC_IN_SEC + timeval.tv_usec / USEC_IN_MSEC;
+	constexpr size_t MSEC_IN_SEC = 1'000;
+	constexpr size_t USEC_IN_MSEC = 1'000;
+	return timeval.tv_sec * MSEC_IN_SEC + timeval.tv_usec / USEC_IN_MSEC;
 }
 
 /**
  * \brief Flow record extension header for storing observed handshake timestamps.
  */
 struct RecordExtTCPRTT : public RecordExt {
 private:
-    constexpr static timeval NO_TIMESTAMP = timeval{std::numeric_limits<time_t>::min(), 0};
+	constexpr static timeval NO_TIMESTAMP = timeval {std::numeric_limits<time_t>::min(), 0};
+
+	constexpr inline static bool has_no_value(timeval timeval) noexcept
+	{
+		return timeval.tv_sec == NO_TIMESTAMP.tv_sec && timeval.tv_usec == NO_TIMESTAMP.tv_usec;
+	}
 
-    constexpr inline static bool has_no_value(timeval timeval) noexcept
-    {
-        return timeval.tv_sec == NO_TIMESTAMP.tv_sec && timeval.tv_usec == NO_TIMESTAMP.tv_usec;
-    }
 public:
-	timeval tcp_syn_timestamp{NO_TIMESTAMP}; ///< Timestamp of last observed TCP SYN packet
-	timeval tcp_synack_timestamp{NO_TIMESTAMP}; ///< Timestamp of last observed TCP SYNACK packet
+	timeval tcp_syn_timestamp {NO_TIMESTAMP}; ///< Timestamp of last observed TCP SYN packet
+	timeval tcp_synack_timestamp {NO_TIMESTAMP}; ///< Timestamp of last observed TCP SYNACK packet
 
-    RecordExtTCPRTT(int pluginID)
+	RecordExtTCPRTT(int pluginID)
 		: RecordExt(pluginID)
 	{
 	}
 
 #ifdef WITH_NEMEA
 	virtual void fill_unirec(ur_template_t* tmplt, void* record)
 	{
-        if (has_no_value(tcp_syn_timestamp) || has_no_value(tcp_synack_timestamp)) {
-		    ur_set(tmplt, record, F_TCPRTT_TIME, std::numeric_limits<uint64_t>::max());
-            return;
-        }
-
-        const ur_time_t round_trip_time = ur_timediff(
-            ur_time_from_sec_usec(tcp_synack_timestamp.tv_sec, tcp_synack_timestamp.tv_usec),
-            ur_time_from_sec_usec(tcp_syn_timestamp.tv_sec, tcp_syn_timestamp.tv_usec));
+		if (has_no_value(tcp_syn_timestamp) || has_no_value(tcp_synack_timestamp)) {
+			ur_set(tmplt, record, F_TCPRTT_TIME, std::numeric_limits<uint64_t>::max());
+			return;
+		}
+
+		const ur_time_t round_trip_time = ur_timediff(
+			ur_time_from_sec_usec(tcp_synack_timestamp.tv_sec, tcp_synack_timestamp.tv_usec),
+			ur_time_from_sec_usec(tcp_syn_timestamp.tv_sec, tcp_syn_timestamp.tv_usec));
 		ur_set(tmplt, record, F_TCPRTT_TIME, round_trip_time);
 	}
 
@@ -82,18 +82,18 @@ struct RecordExtTCPRTT : public RecordExt {
 
 	int fill_ipfix(uint8_t* buffer, int size) override
 	{
-        if (size < static_cast<ssize_t>(sizeof(uint64_t))) {
-            return -1;
-        }
-
-        if (has_no_value(tcp_syn_timestamp) || has_no_value(tcp_synack_timestamp)) {
-            *reinterpret_cast<uint64_t*>(buffer) = std::numeric_limits<uint64_t>::max();
-    		return static_cast<int>(sizeof(uint64_t));
-        }
-
-        const uint64_t round_trip_time =
-            timeval_to_msec(tcp_synack_timestamp) - timeval_to_msec(tcp_syn_timestamp);
-        *reinterpret_cast<uint64_t*>(buffer) = round_trip_time;
+		if (size < static_cast<ssize_t>(sizeof(uint64_t))) {
+			return -1;
+		}
+
+		if (has_no_value(tcp_syn_timestamp) || has_no_value(tcp_synack_timestamp)) {
+			*reinterpret_cast<uint64_t*>(buffer) = std::numeric_limits<uint64_t>::max();
+			return static_cast<int>(sizeof(uint64_t));
+		}
+
+		const uint64_t round_trip_time
+			= timeval_to_msec(tcp_synack_timestamp) - timeval_to_msec(tcp_syn_timestamp);
+		*reinterpret_cast<uint64_t*>(buffer) = round_trip_time;
 		return static_cast<int>(sizeof(round_trip_time));
 	}
 
@@ -108,29 +108,28 @@ struct RecordExtTCPRTT : public RecordExt {
 	{
 		std::ostringstream out;
 
-        if (has_no_value(tcp_syn_timestamp) || has_no_value(tcp_synack_timestamp)) {
-    		out << "tcprtt = UNKNOWN";
-        } else {
-    		out << "tcprtt = " <<
-                timeval_to_msec(tcp_synack_timestamp) - timeval_to_msec(tcp_syn_timestamp);
-        }
+		if (has_no_value(tcp_syn_timestamp) || has_no_value(tcp_synack_timestamp)) {
+			out << "tcprtt = UNKNOWN";
+		} else {
+			out << "tcprtt = "
+				<< timeval_to_msec(tcp_synack_timestamp) - timeval_to_msec(tcp_syn_timestamp);
+		}
 
 		return out.str();
 	}
 };
 
 class TCPRTTPlugin : public ProcessPlugin {
 public:
+	TCPRTTPlugin(const std::string& params, int pluginID);
 
-    TCPRTTPlugin(const std::string& params, int pluginID);
-
-    TCPRTTPlugin(const TCPRTTPlugin&) noexcept;
+	TCPRTTPlugin(const TCPRTTPlugin&) noexcept;
 
-    ~TCPRTTPlugin() override = default;
+	~TCPRTTPlugin() override = default;
 
-    void init(const char* params) override;
+	void init(const char* params) override;
 
-    OptionsParser* get_parser() const override;
+	OptionsParser* get_parser() const override;
 
 	std::string get_name() const override;
 
@@ -143,9 +142,9 @@ class TCPRTTPlugin : public ProcessPlugin {
 	int pre_update(Flow& rec, Packet& pkt) override;
 
 private:
-    void update_tcp_rtt_record(Flow& rec, const Packet& pkt) noexcept;
+	void update_tcp_rtt_record(Flow& rec, const Packet& pkt) noexcept;
 
-    std::unique_ptr<RecordExtTCPRTT> m_prealloced_extension{get_ext()};
+	std::unique_ptr<RecordExtTCPRTT> m_prealloced_extension {get_ext()};
 };
 
-}
+} // namespace ipxp