Skip to content

Commit 8578fe2

Browse files
committed
assert: fix strict regression
Using `assert()` or `assert.ok()` resulted in a error since a refactoring. Refs: nodejs#17582 PR-URL: nodejs#17903 Refs: nodejs#17582 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 968e20c commit 8578fe2

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

lib/assert.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,15 @@ assert.ifError = function ifError(err) { if (err) throw err; };
316316

317317
// Expose a strict only variant of assert
318318
function strict(value, message) {
319-
if (!value) innerFail(value, true, message, '==', strict);
319+
if (!value) {
320+
innerFail({
321+
actual: value,
322+
expected: true,
323+
message,
324+
operator: '==',
325+
stackStartFn: strict
326+
});
327+
}
320328
}
321329
assert.strict = Object.assign(strict, assert, {
322330
equal: assert.strictEqual,

test/parallel/test-assert.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -753,6 +753,14 @@ common.expectsError(
753753
assert.equal(Object.keys(assert).length, Object.keys(a).length);
754754
/* eslint-enable no-restricted-properties */
755755
assert(7);
756+
common.expectsError(
757+
() => assert(),
758+
{
759+
code: 'ERR_ASSERTION',
760+
type: assert.AssertionError,
761+
message: 'undefined == true'
762+
}
763+
);
756764
}
757765

758766
common.expectsError(

0 commit comments

Comments
 (0)