Skip to content

Commit 614dfc3

Browse files
Merge pull request #571 from Brain-up/issue_433
Issue_433_EXERCISES_WORDS_RU_PAGE_links
2 parents 79bb372 + 40d8265 commit 614dfc3

File tree

2 files changed

+10
-46
lines changed

2 files changed

+10
-46
lines changed

pages/exercises_ru_words_page.py

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import time
33
import allure
44
import requests
5+
from selenium.webdriver.support import expected_conditions as EC
56
from selenium.webdriver.support.wait import WebDriverWait as Wait
67
from pages.base_page import BasePage
78
from locators.exercises_ru_words_page_locators import ExercisesRuWordsPageLocators, HeaderLocators
@@ -174,43 +175,20 @@ def get_subgroup_link_status_codes(self):
174175
def click_on_breadcrumbs_links(self):
175176
opened_pages = []
176177
self.element_is_present_and_clickable(self.locators.PAGE_LIST1_1).click()
177-
time.sleep(1)
178+
Wait(self.driver, self.timeout).until(EC.url_changes(self.driver.current_url))
178179
opened_pages.append(self.get_current_tab_url())
179180
self.driver.back()
181+
180182
self.element_is_present_and_clickable(self.locators.PAGE_LIST1_2).click()
181183
opened_pages.append(self.get_current_tab_url())
182184
self.driver.back()
185+
183186
self.element_is_present_and_clickable(self.locators.PAGE_LIST1_3).click()
184-
time.sleep(1)
185187
opened_pages.append(self.get_current_tab_url())
188+
186189
print(*opened_pages, sep='\n')
187190
return opened_pages
188191

189-
@allure.step("Click on breadcrumbs link 1 and thereby open corresponding the web page in the same tab")
190-
def click_on_breadcrumbs_link1(self):
191-
self.element_is_present_and_clickable(self.locators.PAGE_LIST1_1).click()
192-
time.sleep(3)
193-
opened_page = self.get_current_tab_url()
194-
print(opened_page)
195-
self.driver.back()
196-
return opened_page
197-
198-
@allure.step("Click on breadcrumbs link 2 and thereby open corresponding the web page in the same tab")
199-
def click_on_breadcrumbs_link2(self):
200-
self.element_is_present_and_clickable(self.locators.PAGE_LIST1_2).click()
201-
opened_page = self.get_current_tab_url()
202-
print(opened_page)
203-
self.driver.back()
204-
return opened_page
205-
206-
@allure.step("Click on breadcrumbs link 3 and thereby open corresponding the web page in the same tab")
207-
def click_on_breadcrumbs_link3(self):
208-
self.element_is_present_and_clickable(self.locators.PAGE_LIST1_3).click()
209-
opened_page = self.get_current_tab_url()
210-
print(opened_page)
211-
self.driver.back()
212-
return opened_page
213-
214192
@allure.step("Click on group links and thereby open corresponding web pages in the same tab")
215193
def click_on_group_links(self):
216194
opened_pages = []

tests/exercises_ru_words_page_test.py

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -142,26 +142,12 @@ def test_erw_03_03_verify_subgroup_links(self, driver, exercises_ru_words_page_o
142142
assert all(element in erwPD.links_status_code for element in subgroup_links_status_codes), \
143143
"Status codes of subgroup links mismatch valid values"
144144

145-
@allure.title("Verify if breadcrumbs link1 leads to the correct page after clicking")
146-
def test_erw_03_04_01_verify_breadcrumbs_link1_leads_to_correct_page(self, driver, exercises_ru_words_page_open):
145+
@allure.title("Verify if breadcrumbs links lead to correct pages after clicking")
146+
def test_erw_03_04_verify_breadcrumbs_links_navigation(self, driver, exercises_ru_words_page_open):
147147
page = erwPage(driver)
148-
opened_page1 = page.click_on_breadcrumbs_link1()
149-
assert opened_page1, "Transitions to pages have not performed"
150-
assert opened_page1 in erwPD.breadcrumbs_urls, "The link leads to an incorrect page after clicking"
151-
152-
@allure.title("Verify if breadcrumbs link2 leads to the correct page after clicking")
153-
def test_erw_03_04_02_verify_breadcrumbs_link2_leads_to_correct_page(self, driver, exercises_ru_words_page_open):
154-
page = erwPage(driver)
155-
opened_page2 = page.click_on_breadcrumbs_link2()
156-
assert opened_page2, "Transitions to pages have not performed"
157-
assert opened_page2 in erwPD.breadcrumbs_urls, "The link leads to an incorrect page after clicking"
158-
159-
@allure.title("Verify if breadcrumbs link3 leads to the correct page after clicking")
160-
def test_erw_03_04_03_verify_breadcrumbs_link3_leads_to_correct_page(self, driver, exercises_ru_words_page_open):
161-
page = erwPage(driver)
162-
opened_page3 = page.click_on_breadcrumbs_link3()
163-
assert opened_page3, "Transitions to pages have not performed"
164-
assert opened_page3 in erwPD.breadcrumbs_urls, "The link leads to an incorrect page after clicking"
148+
opened_pages = page.click_on_breadcrumbs_links()
149+
assert opened_pages, "Transitions to pages have not performed"
150+
assert all(element in erwPD.breadcrumbs_urls for element in opened_pages), "Links lead to incorrect pages"
165151

166152
@allure.title("Verify if group links lead to correct pages after clicking")
167153
def test_erw_03_05_verify_group_links_lead_to_correct_pages(self, driver, exercises_ru_words_page_open):

0 commit comments

Comments
 (0)