Skip to content

Commit 39a0a40

Browse files
committed
fix e2e failure
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
1 parent 22ea5ff commit 39a0a40

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

cmd/mcs-controller-manager/main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ func setupControllersWithManager(_ context.Context, hubMgr, memberMgr manager.Ma
268268
MemberClient: memberClient,
269269
HubClient: hubClient,
270270
AgentType: clusterv1beta1.MultiClusterServiceAgent,
271+
EnabledNetworkingFeatures: *enableNetworkingFeatures,
271272
}).SetupWithManager(hubMgr); err != nil {
272273
klog.ErrorS(err, "Unable to create internalmembercluster (v1beta1 API) reconciler")
273274
return err

cmd/member-net-controller-manager/main.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func init() {
8989
utilruntime.Must(fleetnetv1beta1.AddToScheme(scheme))
9090
utilruntime.Must(fleetv1alpha1.AddToScheme(scheme))
9191
utilruntime.Must(clusterv1beta1.AddToScheme(scheme))
92-
92+
9393
//+kubebuilder:scaffold:scheme
9494
}
9595

@@ -295,6 +295,7 @@ func setupControllersWithManager(ctx context.Context, hubMgr, memberMgr manager.
295295
MemberClient: memberClient,
296296
HubClient: hubClient,
297297
AgentType: clusterv1beta1.ServiceExportImportAgent,
298+
EnabledNetworkingFeatures: *enableNetworkingFeatures, // Pass the flag to the reconciler
298299
}).SetupWithManager(hubMgr); err != nil {
299300
klog.ErrorS(err, "Unable to create internalmembercluster (v1beta1 API) reconciler")
300301
return err

pkg/controllers/member/internalmembercluster/v1beta1/controller_v1beta1.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ type Reconciler struct {
3939
MemberClient client.Client
4040
HubClient client.Client
4141
AgentType clusterv1beta1.AgentType
42+
EnabledNetworkingFeatures bool
4243
}
4344

4445
//+kubebuilder:rbac:groups=cluster.kubernetes-fleet.io,resources=internalmemberclusters,verbs=get;list;watch
@@ -74,12 +75,12 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
7475
klog.V(2).InfoS("member cluster has left the fleet; performing cleanup", "internalMemberCluster", imcKRef)
7576

7677
// Clean up fleet networking related resources.
77-
if r.AgentType == clusterv1beta1.MultiClusterServiceAgent {
78+
if r.AgentType == clusterv1beta1.MultiClusterServiceAgent && r.EnabledNetworkingFeatures{
7879
if err := r.cleanupMCSRelatedResources(ctx); err != nil {
7980
return ctrl.Result{}, err
8081
}
8182
}
82-
if r.AgentType == clusterv1beta1.ServiceExportImportAgent {
83+
if r.AgentType == clusterv1beta1.ServiceExportImportAgent && r.EnabledNetworkingFeatures {
8384
if err := r.cleanupServiceExportRelatedResources(ctx); err != nil {
8485
return ctrl.Result{}, err
8586
}

test/e2e/join_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ var _ = Describe("Test Join/Leave workflow", Serial, Ordered, func() {
325325
Skip("Skipping setting up when networking features are enabled")
326326
}
327327
})
328-
328+
329329
Context("Member cluster agents should join/leave fleet", func() {
330330
BeforeEach(func() {
331331
By("Creating internalMemberCluster")

0 commit comments

Comments
 (0)