Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

chore: force containerd runtime for Kubernetes v1.24+ on Azure Stack Hub - #5058

Merged
Javier Darsie (jadarsie) merged 3 commits into
Azure:masterfrom
christinalau0:124-containerd-ash
Jan 26, 2023
Merged

chore: force containerd runtime for Kubernetes v1.24+ on Azure Stack Hub#5058
Javier Darsie (jadarsie) merged 3 commits into
Azure:masterfrom
christinalau0:124-containerd-ash

Conversation

@christinalau0

Copy link
Copy Markdown
Contributor

Reason for Change:

Only impacts Azure Stack Hub

  • force overwrite from docker to containerd for upgrade
  • set containerd as default container runtime for deploy/generate
  • add unit test
  • fix validate windows image on ash stamps

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

- force overwrite for deploy, generate, upgrade
- add unit test
- fix validate windows image on ash stamps
@jadarsie Javier Darsie (jadarsie) changed the title chore: set containerd as default on Azure Stack Hub for v1.24+ chore: force containerd runtime for Kubernetes v1.24+ on Azure Stack Hub Jan 25, 2023
@jadarsie

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

verified change to mock client does not impact any other unit tests
@jadarsie

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jadarsie
Javier Darsie (jadarsie) merged commit 3706bd3 into Azure:master Jan 26, 2023
Javier Darsie (jadarsie) pushed a commit that referenced this pull request Jan 26, 2023
…Hub (#5058)

* chore: set containerd as default on ash for v1.24+

- force overwrite for deploy, generate, upgrade
- add unit test
- fix validate windows image on ash stamps

* Change debug statement

* test: support validator test needs containerd image from mock client

verified change to mock client does not impact any other unit tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants