Skip to content

Commit 069bca4

Browse files
committed
chore: update to Node 20
1 parent 4fc3b12 commit 069bca4

File tree

8 files changed

+12
-15
lines changed

8 files changed

+12
-15
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,10 @@
44
"name": "Azure Search OpenAI Js",
55

66
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
7-
"image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
7+
"image": "mcr.microsoft.com/devcontainers/javascript-node:22-bookworm",
88

99
// Features to add to the dev container. More info: https://containers.dev/features.
1010
"features": {
11-
"ghcr.io/devcontainers/features/node:1": {
12-
"version": "18"
13-
},
1411
"ghcr.io/devcontainers/features/docker-in-docker:2": {
1512
"version": 20,
1613
"moby": "false"

.github/workflows/azure-dev.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ jobs:
3131
uses: actions/checkout@v4
3232

3333
- name: Install azd
34-
uses: Azure/setup-azd@v0.1.0
34+
uses: Azure/setup-azd@v2
3535

3636
- name: Install Nodejs
3737
uses: actions/setup-node@v4
3838
with:
39-
node-version: 18
39+
node-version: 20
4040

4141
- name: Log in with Azure (Federated Credentials)
4242
if: ${{ env.AZURE_CLIENT_ID != '' }}

.github/workflows/build-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
matrix:
1616
platform: [ubuntu-latest, macos-latest, windows-latest]
17-
node-version: ['18']
17+
node-version: ['20']
1818

1919
name: ${{ matrix.platform }} / Node.js v${{ matrix.node-version }}
2020
runs-on: ${{ matrix.platform }}

.github/workflows/playwright.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
- uses: actions/checkout@v4
1313
- uses: actions/setup-node@v4
1414
with:
15-
node-version: 18
15+
node-version: 20
1616
- name: Install dependencies
1717
run: npm ci
1818
- name: Install Playwright Browsers

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18
1+
20

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@
4343
"tap": "^18.5.2"
4444
},
4545
"engines": {
46-
"node": ">=18",
47-
"npm": ">=9"
46+
"node": ">=20",
47+
"npm": ">=10"
4848
},
4949
"simple-git-hooks": {
5050
"pre-commit": "npx lint-staged"

packages/indexer/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# Build Node.js app
44
# ------------------------------------
5-
FROM node:18-alpine as build
5+
FROM node:20-alpine as build
66
WORKDIR /app
77
COPY ./package*.json ./
88
COPY ./packages/indexer ./packages/indexer
@@ -11,7 +11,7 @@ RUN npm run build --workspace=indexer
1111

1212
# Run Node.js app
1313
# ------------------------------------
14-
FROM node:18-alpine
14+
FROM node:20-alpine
1515
ENV NODE_ENV=production
1616

1717
WORKDIR /app

packages/search/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# Build Node.js app
44
# ------------------------------------
5-
FROM node:18-alpine as build
5+
FROM node:20-alpine as build
66
WORKDIR /app
77
COPY ./package*.json ./
88
COPY ./packages/search ./packages/search
@@ -11,7 +11,7 @@ RUN npm run build --workspace=search
1111

1212
# Run Node.js app
1313
# ------------------------------------
14-
FROM node:18-alpine
14+
FROM node:20-alpine
1515
ENV NODE_ENV=production
1616

1717
WORKDIR /app

0 commit comments

Comments
 (0)