Skip to content

Commit 2dd2e36

Browse files
anomiexmatticbot
authored andcommitted
Remove most pnpm hoisting, fix phantom deps (#24096)
We've long had pnpm's public hoisting disabled, but it also privately hoists everything into `node_modules/.pnpm/node_modules/` for compatibility with packages that have undeclared dependencies. Let's disable most of that private hoisting and see what turns up. Changes of note: * We still hoist a bunch of eslint plugins (and one prettier plugin) as untangling that mess seems like enough work to put off for later. * Only a few upstream packages have bugs that need working around: * `@mdx-js/loader`: mdx-js/mdx#2019 * `@automattic/components`: Missing dep on `@wordpress/base-styles`. And the next version will probably be unusable for us due to added `i18n-calypso`. * `@automattic/popup-monitor`: Missing dep on `events`. * markdown-it`: Missing dep on `punycode`. markdown-it/markdown-it#230 * `@samverschueren/stream-to-observable`: Outdated dep on `any-observable`. SamVerschueren/stream-to-observable#9 Hacking around that should also fix p1649254510834369-slack-CBG1CP4EN. * `git-node-fs`: Missing peer dep on `js-git`. creationix/git-node-fs#8 * `fetch-mock`'s peer dep on `node-fetch` is optional, but only because they also allow running in-browser. It's required for node. * Added `webpack-cli` alongside `webpack` everywhere to make sure p1650571211251179-slack-CBG1CP4EN is fixed. Dropped Webpack entirely from Boost instead though, they don't use it. * Had our webpack-config package point to its own copy of `@babel/runtime` instead of making that a peer dep. * Jetpack's extensions tests use a ton of `@wordpress/` packages that weren't being directly depended on. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/2234009376
1 parent 0620b87 commit 2dd2e36

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [1.0.7-alpha] - unreleased
9+
10+
This is an alpha version! The changes listed here are not final.
11+
12+
### Added
13+
- Add missing JavaScript dependencies.
14+
815
## [1.0.6] - 2022-04-26
916
### Changed
1017
- Update package.json metadata.
@@ -41,6 +48,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4148
### Added
4249
- Initial release.
4350

51+
[1.0.7-alpha]: https://github.com/Automattic/remove-asset-webpack-plugin/compare/v1.0.6...v1.0.7-alpha
4452
[1.0.6]: https://github.com/Automattic/remove-asset-webpack-plugin/compare/v1.0.5...v1.0.6
4553
[1.0.5]: https://github.com/Automattic/remove-asset-webpack-plugin/compare/v1.0.4...v1.0.5
4654
[1.0.4]: https://github.com/Automattic/remove-asset-webpack-plugin/compare/v1.0.3...v1.0.4

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@automattic/remove-asset-webpack-plugin",
3-
"version": "1.0.6",
3+
"version": "1.0.7-alpha",
44
"description": "A Webpack plugin to remove assets from the build.",
55
"homepage": "https://github.com/Automattic/jetpack/tree/HEAD/projects/js-packages/remove-asset-webpack-plugin/README.md#readme",
66
"bugs": {
@@ -22,7 +22,8 @@
2222
},
2323
"devDependencies": {
2424
"jest": "27.3.1",
25-
"webpack": "5.65.0"
25+
"webpack": "5.65.0",
26+
"webpack-cli": "4.9.1"
2627
},
2728
"peerDependencies": {
2829
"webpack": "^5.8.0"

0 commit comments

Comments
 (0)