Skip to content

Commit ee1d975

Browse files
authored
Remove fee text liquidity (#1420)
* remove fee in add liquidity form * remove text dealing with fees added back to pool * fix resolution rules not showing up
1 parent fe6ac12 commit ee1d975

File tree

4 files changed

+9
-46
lines changed

4 files changed

+9
-46
lines changed

packages/comps/src/utils/derived-market-data.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,19 @@ import * as GroupedFetcher from "./fetcher-grouped";
2424

2525
export const getResolutionRules = (marketInfo: MarketInfo): string[] => {
2626
switch (marketInfo.marketFactoryType) {
27-
case MARKET_FACTORY_TYPES.SPORTSLINK: {
28-
return SimpleSportsDailies.getResolutionRules(marketInfo);
29-
}
3027
case MARKET_FACTORY_TYPES.CRYPTO: {
3128
return CryptoMarkets.getResolutionRules(marketInfo);
3229
}
30+
case MARKET_FACTORY_TYPES.MMA:
3331
case MARKET_FACTORY_TYPES.MMALINK: {
3432
return MmaDailies.getResolutionRules(marketInfo);
3533
}
36-
case MARKET_FACTORY_TYPES.NFL: {
37-
return NflMarkets.getResolutionRules(marketInfo);
38-
}
3934
case MARKET_FACTORY_TYPES.GROUPED: {
4035
return GroupedMarkets.getResolutionRules(marketInfo);
4136
}
4237
default:
43-
return [];
38+
// NFL, MLB, NBA, NHL
39+
return SimpleSportsDailies.getResolutionRules(marketInfo);
4440
}
4541
};
4642

packages/comps/src/utils/derived-nfl-dailies.ts

Lines changed: 2 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { BigNumber as BN } from "bignumber.js";
22
import { MarketInfo } from "types";
33
import { NO_CONTEST_OUTCOME_ID, SPORTS_MARKET_TYPE } from "./constants";
44
import { getSportTypeCategories, getSportTypeSportId } from "./team-helpers";
5+
import * as SimpleSportsDailies from "./derived-simple-sport-dailies";
56

67
const NAMING_TEAM = {
78
HOME_TEAM: "HOME_TEAM",
@@ -147,10 +148,7 @@ const getSportsTitles = (sportsMarketType: number): { title: string; description
147148
};
148149

149150
export const getResolutionRules = (market: MarketInfo): string[] => {
150-
if (market.sportsMarketType === undefined) return [];
151-
const { sportsMarketType } = market;
152-
if (!sportsResolutionRules[sportsMarketType]) return [];
153-
return sportsResolutionRules[sportsMarketType];
151+
return SimpleSportsDailies.getResolutionRules(market);
154152
};
155153

156154
const getMarketOutcome = (sportsMarketType: number, outcomeId: number): string => {
@@ -208,34 +206,3 @@ const sportsData = {
208206
outcomes: [NO_CONTEST, `Over ${NAMING_LINE.OVER_UNDER_LINE}.5`, `Under ${NAMING_LINE.OVER_UNDER_LINE}.5`],
209207
},
210208
};
211-
212-
// TODO: Rules might change depending on how contract resolves over/under MMA markets, need to verify after contract is written
213-
const sportsResolutionRules = {
214-
[SPORTS_MARKET_TYPE.MONEY_LINE]: [
215-
`At least 55 minutes of play must have elapsed for the game to be deemed official. If the game is not played or if less than 55 minutes of play have been completed, the game is not considered
216-
an official game and the market should resolve as 'No Contest'.`,
217-
`Overtime counts towards settlement purposes.`,
218-
`If the game ends in a tie, the market should resolve as 'No Contest'`,
219-
`If the game is not played, the market should resolve as 'No Contest'.`,
220-
`Results are determined by their natural conclusion and do not recognize postponed games,
221-
protests, or overturned decisions.`,
222-
],
223-
[SPORTS_MARKET_TYPE.SPREAD]: [
224-
`At least 55 minutes of play must have elapsed for the game to be deemed official. If the game is
225-
not played or if less than 55 minutes of play have been completed, the game is not considered
226-
an official game and the market should resolve as 'No Contest'.`,
227-
`Overtime counts towards settlement purposes.`,
228-
`If the game is not played, the market should resolve as 'No Contest'.`,
229-
`Results are determined by their natural conclusion and do not recognize postponed games,
230-
protests, or overturned decisions.`,
231-
],
232-
[SPORTS_MARKET_TYPE.OVER_UNDER]: [
233-
`At least 55 minutes of play must have elapsed for the game to be deemed official. If the game is
234-
not played or if less than 55 minutes of play have been completed, the game is not considered
235-
an official game and the market should resolve as 'No Contest'.`,
236-
`Overtime count towards settlement purposes.`,
237-
`If the game is not played, the market should resolve as 'No Contest'.`,
238-
`Results are determined by their natural conclusion and do not recognize postponed games,
239-
protests, or overturned decisions.`,
240-
],
241-
};

packages/comps/src/utils/derived-simple-sport-dailies.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ const sportsData = {
317317

318318
const sportsResolutionRules = {
319319
"2": {
320+
// NFL
320321
types: {
321322
[SPORTS_MARKET_TYPE.MONEY_LINE]: [
322323
`At least 55 minutes of play must have elapsed for the game to be deemed official. If the game is not played or if less than 55 minutes of play have been completed, the game is not considered
@@ -348,6 +349,7 @@ protests, or overturned decisions.`,
348349
},
349350
},
350351
"3": {
352+
// MLB
351353
types: {
352354
[SPORTS_MARKET_TYPE.MONEY_LINE]: [
353355
`The results of a game are official after (and, unless otherwise stated, bets shall be settled subject to the completion of) 5 innings of play, or 4.5 innings should the home team be leading at the commencement of the bottom of the 5th innings. Should a game be called, if the result is official in accordance with this rule, the winner will be determined by the score/stats after the last completed inning.`,
@@ -373,6 +375,7 @@ protests, or overturned decisions.`,
373375
},
374376
},
375377
"4": {
378+
// NBA
376379
types: {
377380
[SPORTS_MARKET_TYPE.MONEY_LINE]: [
378381
`At least 43 minutes of play must have elapsed for the game to be deemed official. If the game is not played or if less than 43 minutes of play have been completed, the game is not considered an official game and the market should resolve as 'No Contest'.`,
@@ -395,6 +398,7 @@ protests, or overturned decisions.`,
395398
},
396399
},
397400
"6": {
401+
// NHL
398402
types: {
399403
[SPORTS_MARKET_TYPE.MONEY_LINE]: [
400404
`At least 55 minutes of play must have elapsed for the game to be deemed official. If the game is not played or if less than 55 minutes of play have been completed, the game is not considered an official game and the market should resolve as 'No Contest'.`,

packages/simplified/src/modules/liquidity/market-liquidity-view.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,6 @@ const BackBar = ({ BackToLPPageAction, selectedAction, setSelectedAction, setAmo
166166

167167
const LiquidityWarningFooter = () => (
168168
<article className={Styles.LiquidityWarningFooter}>
169-
<p>
170-
By adding liquidity you'll earn 1.50% of all trades on this market proportional to your share of the pool. Fees
171-
are added to the pool, accrue in real time and can be claimed by withdrawing your liquidity.
172-
</p>
173169
<span>{WarningIcon} Remove liquidity before the winning outcome is known to prevent any loss of funds</span>
174170
</article>
175171
);

0 commit comments

Comments
 (0)