fix: use array.tosorted instead of array.sort (#3823)

## Proposed change

Preserve immutability of arrays by using `Array.toSorted` instead of
`Array.sort` so a copy is created instead of modifying the input

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- *  Pull Request #issue -->

Author: fpaul-1A

apps/chrome-devtools/src/app-devtools/theming-panel/theming-panel-pres.ts

@@ -236,7 +236,7 @@ export class ThemingPanelPres {
           isPalette,
           defaultVariable
         }]);
-      }, []).sort((a, b) => {
+      }, []).toSorted((a, b) => {
         // Others should go at the end
         if (a.name === 'others') {
           return 1;

apps/github-cascading-app/src/cascading/cascading-probot.ts

@@ -253,7 +253,7 @@ export class CascadingProbot extends Cascading {
     const { data } = await this.options.octokit.rest.pulls.list(this.options.repo);
     return data
       .filter(({ head, base }) => (!targetBranch || base.ref === targetBranch) && (!baseBranch || head.ref === baseBranch))
-      .sort((prA, prB) => (Date.parse(prA.created_at) - Date.parse(prB.created_at)))
+      .toSorted((prA, prB) => (Date.parse(prA.created_at) - Date.parse(prB.created_at)))
       .map((pr): CascadingPullRequestInfo => ({
         ...pr,
         originBranchName: pr.head.ref,

apps/github-cascading-app/src/cascading/cascading.ts

@@ -197,7 +197,7 @@ export abstract class Cascading {
         }
         return true;
       })
-      .sort((branchObjectA, branchObjectB) => {
+      .toSorted((branchObjectA, branchObjectB) => {
         if (!branchObjectA.semver) {
           return 1;
         } else if (!branchObjectB.semver) {

apps/showcase/src/components/showcase/sdk/sdk-pres.ts

@@ -149,7 +149,7 @@ export class SdkPres {
     this.isLoading.set(true);
     this.hasErrors.set(false);
     return this.petStoreApi.findPetsByStatus({ status: 'available' }).then((pets) => {
-      this.pets.set(pets.filter((p) => p.category?.name === 'otter').sort((a, b) => (a.id && b.id && (a.id - b.id)) || 0));
+      this.pets.set(pets.filter((p) => p.category?.name === 'otter').toSorted((a, b) => (a.id && b.id && (a.id - b.id)) || 0));
       this.isLoading.set(false);
     }).catch(() => {
       this.isLoading.set(false);

apps/showcase/tsconfig.app.json

@@ -36,7 +36,7 @@
     "jsx": "react",
     "allowSyntheticDefaultImports": true,
     "lib": [
-      "ES2022",
+      "ES2024",
       "es6",
       "dom",
       "dom.iterable"

apps/vscode-extension/src/commands/helpers.ts

@@ -51,7 +51,7 @@ const getInfoFromWorkspaceJsonUris = async <T>(
   getInfo: (workspaceJsonUri: vscode.Uri) => Promise<T | undefined>
 ) => {
   const workspaceJsonUris = await vscode.workspace.findFiles('{angular,nx}.json');
-  const sortedWorkspaceJsonUris = workspaceJsonUris.sort(sortWorkspaceUris);
+  const sortedWorkspaceJsonUris = workspaceJsonUris.toSorted(sortWorkspaceUris);
   for (const workspaceJsonUri of sortedWorkspaceJsonUris) {
     const infoFromWorkspace = await getInfo(workspaceJsonUri);
     if (infoFromWorkspace) {

packages/@ama-mcp/github/src/find-repositories-using-library/index.spec.ts

@@ -192,8 +192,8 @@ describe('Find repositories using library', () => {
     }]);
     expect(response.structuredContent).toEqual(expect.objectContaining({
       repositories: [
-        'testOrg/repo1',
-        'testOrg/repoCached'
+        'testOrg/repoCached',
+        'testOrg/repo1'
       ]
     }));
   });

packages/@ama-mcp/github/src/find-repositories-using-library/index.ts

@@ -234,7 +234,7 @@ export function registerGetRepositoriesUsingLibraryTool(server: McpServer, optio
             text: (isLookingForRepos ? 'I did not finish to look for repositories. For the moment:\n' : '')
               + reposUsingLibrary.length
               ? `The following repositories use ${libraryName} dependencies:\n`
-              + reposUsingLibrary.sort().map((repo) => `- ${repo}`).join('\n')
+              + reposUsingLibrary.toSorted().map((repo) => `- ${repo}`).join('\n')
               : `No repositories found using ${libraryName} dependencies.`
           }
         ],

packages/@ama-sdk/schematics/schematics/typescript/mock/index.ts

@@ -66,7 +66,7 @@ function ngGenerateMockFn(options: NgGenerateMockSchematicsSchema): Rule {
       if (!(new RegExp(`./${dasherizeModelName}/index`).test(currentComponentIndex))) {
         currentComponentIndex = `export * from './${dasherizeModelName}/index';\n` + currentComponentIndex;
       }
-      currentComponentIndex = `${currentComponentIndex.split('\n').filter((e) => !!e).sort().join('\n')}\n`;
+      currentComponentIndex = `${currentComponentIndex.split('\n').filter((e) => !!e).toSorted().join('\n')}\n`;
       tree.overwrite(barrelPath, currentComponentIndex);
     }
     return tree;

packages/@ama-sdk/schematics/schematics/typescript/shell/index.spec.ts

@@ -109,7 +109,7 @@ describe('Typescript Shell Generator', () => {
   });
 
   it('should generate basic SDK package', () => {
-    expect(yarnTree.files.sort()).toEqual(baseFileList.sort());
+    expect(yarnTree.files.toSorted()).toEqual(baseFileList.toSorted());
   });
 
   it('should generate correct package name', () => {