Skip to content

Commit 0a91caa

Browse files
authored
Merge pull request #112 from Altinity/release-0.3.0
dev: retry for CREATE and DROP TABLE
2 parents adbbe9e + 8f07ad0 commit 0a91caa

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

pkg/controller/chi/controller.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -540,11 +540,11 @@ func (c *Controller) onUpdateChi(old, new *chop.ClickHouseInstallation) error {
540540
new.WalkClusters(func(cluster *chop.ChiCluster) error {
541541
dbNames, createDatabaseSQLs, _ := c.schemer.ClusterGetCreateDatabases(new, cluster)
542542
glog.V(1).Infof("Creating databases: %v", dbNames)
543-
_ = c.schemer.ClusterApplySQLs(cluster, createDatabaseSQLs, false)
543+
_ = c.schemer.ClusterApplySQLs(cluster, createDatabaseSQLs, true)
544544

545545
tableNames, createTableSQLs, _ := c.schemer.ClusterGetCreateTables(new, cluster)
546546
glog.V(1).Infof("Creating tables: %v", tableNames)
547-
_ = c.schemer.ClusterApplySQLs(cluster, createTableSQLs, false)
547+
_ = c.schemer.ClusterApplySQLs(cluster, createTableSQLs, true)
548548
return nil
549549
})
550550
_ = c.updateCHIResource(new)

pkg/controller/chi/deleters.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func (c *Controller) deleteTablesOnReplica(replica *chop.ChiReplica) {
3838
// Delete tables on replica
3939
tableNames, dropTableSQLs, _ := c.schemer.ReplicaGetDropTables(replica)
4040
glog.V(1).Infof("Drop tables: %v as %v", tableNames, dropTableSQLs)
41-
_ = c.schemer.ReplicaApplySQLs(replica, dropTableSQLs, false)
41+
_ = c.schemer.ReplicaApplySQLs(replica, dropTableSQLs, true)
4242
}
4343

4444
// deleteReplica deletes all kubernetes resources related to replica *chop.ChiReplica

pkg/model/clickhouse/clickhouse.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ func (c *Conn) Exec(sql string) error {
108108
}
109109

110110
if err := connect.Ping(); err != nil {
111-
glog.V(1).Infof("FAILED Ping(%d) %v for SQL: %s", dsn, err, sql)
111+
glog.V(1).Infof("FAILED Ping(%s) %v for SQL: %s", dsn, err, sql)
112112
return err
113113
}
114114

0 commit comments

Comments
 (0)