Skip to content

Conversation

sharadgaur
Copy link
Contributor

@sharadgaur sharadgaur commented Aug 29, 2025

Summary

  • Fix INDEX statement parsing bug where dotted column names (e.g., common.id) were missing spaces in string output
  • Ensure parenthesized expressions in INDEX statements don't get unwanted extra spaces

Changes

  • parser/ast.go: Fix TableIndex.String() method spacing logic for column expressions
  • Test files: Update golden test files to reflect corrected INDEX formatting

Bug Fix Details

Before: INDEX id_common_id_bloom_filtercommon.id TYPE bloom_filter(0.001) GRANULARITY 1
After: INDEX id_common_id_bloom_filter common.id TYPE bloom_filter(0.001) GRANULARITY 1

@sharadgaur sharadgaur changed the title Update Go to 1.24.0 and fix INDEX column spacing bug BugFix: INDEX column spacing bug Aug 29, 2025
Signed-off-by: Sharad Gaur <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17335471641

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.387%

Totals Coverage Status
Change from base Build 17258338401: 0.0%
Covered Lines: 7422
Relevant Lines: 14730

💛 - Coveralls

@git-hulk git-hulk changed the title BugFix: INDEX column spacing bug Fix INDEX column spacing bug Sep 1, 2025
@git-hulk git-hulk merged commit 171c3e8 into AfterShip:master Sep 1, 2025
2 of 3 checks passed
@git-hulk
Copy link
Member

git-hulk commented Sep 1, 2025

@sharadgaur Thanks for your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants