fix(webp): Move write_complete_data() to close() for proper scanline order support

The WebP output plugin incorrectly assumed that scanlines would be written
in sequential order, triggering the final write when y == height - 1.
This violated the write_scanline API contract which allows scanlines to
be written in any order (the plugin even advertises 'random_access' support).

Changes:
- Remove premature write_complete_data() call from write_scanline()
- Move final encoding/writing to close() where it belongs
- Add m_image_complete flag to track write state
- Move buffer cleanup to after write_complete_data() in close()

Fixes the issue where writing scanlines out of order would result in
incomplete or corrupted WebP files.

Signed-off-by: pmady <[email protected]>

Author: pmady

src/webp.imageio/webpoutput.cpp

@@ -39,10 +39,12 @@ class WebpOutput final : public ImageOutput {
     unsigned int m_dither;
     bool m_convert_alpha;  // Do we deassociate alpha?
     std::vector<uint8_t> m_uncompressed_image;
+    bool m_image_complete;  // Has all image data been written?
 
     void init()
     {
-        m_scanline_size = 0;
+        m_scanline_size  = 0;
+        m_image_complete = false;
         ioproxy_clear();
     }
 
@@ -238,11 +240,6 @@ WebpOutput::write_scanline(int y, int z, TypeDesc format, const void* data,
     std::vector<uint8_t> scratch;
     data = to_native_scanline(format, data, xstride, scratch, m_dither, y, z);
     memcpy(&m_uncompressed_image[y * m_scanline_size], data, m_scanline_size);
-
-    /* If this was the final scanline, we are done. */
-    if (y == m_spec.height - 1) {
-        return write_complete_data();
-    }
     return true;
 }
 
@@ -271,9 +268,16 @@ WebpOutput::close()
         OIIO_DASSERT(m_uncompressed_image.size());
         ok &= write_scanlines(m_spec.y, m_spec.y + m_spec.height, 0,
                               m_spec.format, &m_uncompressed_image[0]);
-        std::vector<uint8_t>().swap(m_uncompressed_image);
     }
 
+    // Write the complete image data on close, not during write_scanline.
+    // This allows scanlines to be written in any order.
+    if (ok && !m_image_complete && m_uncompressed_image.size()) {
+        ok = write_complete_data();
+        m_image_complete = true;
+    }
+
+    std::vector<uint8_t>().swap(m_uncompressed_image);
     WebPPictureFree(&m_webp_picture);
     init();
     return ok;