Skip to content

LPC546XX, LPC54114: Add README and LICENSE files for the power libraries #9360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

LPC546XX, LPC54114: Add README and LICENSE files for the power libraries #9360

merged 1 commit into from
Jan 22, 2019

Conversation

mmahadevan108
Copy link
Contributor

Description

This is a fix for Issue #9254

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mmahadevan108
LPC546XX, LPC54114: Add README and LICENSE files for the power libraries
a11e201 
This is a fix for Issue#9254

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @maclobdell

@ciarmcom ciarmcom requested a review from a team January 11, 2019 22:00
@ciarmcom
Copy link
Member

@mmahadevan108, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Jan 14, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding readme + license

One question: the license looks similar to PBL but not the same, what is this license? can it be released under Permissive Binary License?

@mmahadevan108
Copy link
Contributor Author

+1 for adding readme + license

One question: the license looks similar to PBL but not the same, what is this license? can it be released under Permissive Binary License?

I am not familiar with PBL, this is the clear BSD license:
https://spdx.org/licenses/BSD-3-Clause-Clear.html#licenseText

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2019

Test restarted

@0xc0170 0xc0170 merged commit 813f5ac into ARMmbed:master Jan 22, 2019
@0xc0170 0xc0170 mentioned this pull request Jan 22, 2019
Closed
@mmahadevan108 mmahadevan108 deleted the LPC_PowerLib_Readme_License branch February 19, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmahadevan108 @ciarmcom @0xc0170 @mbed-ci