Align prototype & implementation of enet_tasklet_disconnect & friends #9100
Conversation
|
Original fix 7e7af77 coerces an int8_t to nsapi_error_t, which is incorrect (nsapi_error_t is an enum with specific values) |
|
@deece, thank you for your changes. |
| @@ -97,5 +97,6 @@ nsapi_error_t NanostackEthernetInterface::do_initialize() | |||
|
|
|||
| nsapi_error_t Nanostack::EthernetInterface::bringdown() | |||
| { | |||
| return enet_tasklet_disconnect(true); | |||
| (void)enet_tasklet_disconnect(true); | |||
There was a problem hiding this comment.
This should be turning an error into some sort of nsapi error code, rather than swallowing it. I guess DEVICE_ERROR would do.
There was a problem hiding this comment.
I did contemplate that (it does make sense), but the original code swallowed it, and without a way to test it, I didn't think it would be good to alter the behavior.
| @@ -20,6 +20,7 @@ | |||
| #include "net_interface.h" | |||
| #include "ip6string.h" //ip6tos | |||
| #include "nsdynmemLIB.h" | |||
| #include "include/enet_tasklet.h" | |||
There was a problem hiding this comment.
There is already an include of enet_tasklet.h below?
There was a problem hiding this comment.
Bad merge :) I'll remove it
Rework of ARMmbed#8698 Signed-off-by: Alastair D'Silva <[email protected]>
|
@SeppoTakalo Please take a look. Should be similar to #8698, which was OK'd before. |
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Description
Rework of #8698
Aligns the prototype and implementation of enet_tasklet_disconnect.
Pull request type