Skip to content

memap.py: Cope with IAR 8 linker map #8980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Dec 5, 2018

Description

IAR 8 linker map puts C++14-style apostrophe digit separators in its addresses, such as:

 .data   inited  0x2000'1ff0    0x4  mbed_rtx_idle.o [159]

Extend the regex pattern to allow this.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

IAR 8 linker map puts C++14-style apostrophe digit separators in its
addresses, such as:

     .data   inited  0x2000'1ff0    0x4  mbed_rtx_idle.o [159]

Extend the regex pattern to allow this.
@ciarmcom ciarmcom requested review from a team December 5, 2018 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 5, 2018

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Dec 5, 2018

Well, I suppose they're allowed to do that kind of change, since moving from 7 to 8 would alllow for breaking changes.

Any particular reason for not doing something like \w{4}\'?\w{4}, to be a bit stricter?

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Thanks!

@theotherjimmy
Copy link
Contributor

@kjbracey-arm I'd classify this as a fix.

@cmonr
Copy link
Contributor

cmonr commented Dec 6, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 6, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 211c662 into ARMmbed:master Dec 7, 2018
@kjbracey kjbracey deleted the iar8_memap branch December 7, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants