Skip to content

fixed wrong __StackTop calculation #8978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2018
Merged

fixed wrong __StackTop calculation #8978

merged 1 commit into from
Dec 14, 2018

Conversation

JojoS62
Copy link
Contributor

@JojoS62 JojoS62 commented Dec 5, 2018 •
edited
Loading

Description

StackTop calculation was not adjusted when ram size was increased by using al 3 ram regions.
This caused memory allocation failures althogh enough free heap was reported

The problem applies to GCC_ARM toolchain.
IAR and ARM toolchain setting looks fine, but I cannot verify this.
GCC_CR settings look also fine, but GCC_CR support has been removed already.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@JojoS62
fixed wrong __StackTop calculation
cb72db2 
StackTop calculation was not adjusted when ram size was increased by using al 3 ram regions.
This caused memory allocation failures althogh enough free heap was reported
@0xc0170 0xc0170 requested a review from a team December 5, 2018 13:57
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2018

@mmahadevan108 Can you review please

@JojoS62 JojoS62 mentioned this pull request Dec 5, 2018
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 12, 2018

@mmahadevan108 Can you review please

Still waiting for review

mmahadevan108
mmahadevan108 approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@cmonr
Copy link
Contributor

cmonr commented Dec 12, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 13, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 49103d8 into ARMmbed:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JojoS62 @0xc0170 @cmonr @mbed-ci @mmahadevan108