Online: Include project root path #8660
Conversation
### Description
The prior logic assumed that "." would not be added to the include
paths, indicating that the project root would not be added to the
include paths correctly in the online environment ("." would be
incorrect there). This change set started by removing the addition
of "*.", and then fixed building from there.
### Pull request type
[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
|
Out of curiosity, why was the prior logic needed to begin with? Seems like this new behavior is more generic to begin with. |
|
@cmonr I think it was using |
|
/morph build |
|
One failure (nothing uploaded to s3, can't locate the exact failure at the moment) - build aborted |
Build : FAILUREBuild number : 3578 |
|
The true problem, in case you were wondering:
|
|
Hmm, would encapsulating the parameters in quotes help, or are you specifically trying to avoid that? |
### Description
The prior fix made the assumption that you wanted to compute all of the
parents for a give header file going all the way up the path. This is
not true: you probably want to stop when the project stops. We already
keep track of a virtual name within the project, so instead, we compute
parents of the name, and generate the actual location of these files in
your FS as the path. This makes the solution robust offline and online
(I tested it with my local copy of os.mbed.com)
### Pull request type
[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
|
@cmonr Good guess, but that would not help much/at all. The problem was computing parents past the project's root directory. I sorted that with the new commit. |
|
Note: This PR is now a part of a rollup PR (#8686). No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
Description
The prior logic assumed that "." would not be added to the include
paths, indicating that the project root would not be added to the
include paths correctly in the online environment ("." would be
incorrect there). This change set started by removing the addition
of ".", and then fixed building from there.
Pull request type