Add Support for TOSHIBA TMPM3HQ #8324

ghost · 2018-10-04T11:20:44Z

Description

Add mbed support for TOSHIBA's TMPM3HQ board

Tested with all toolchains and test results are attached.
M3HQ_GreenteaAutomated_TestResults.txt

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Breaking change

0xc0170 · 2018-10-04T11:42:24Z

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Can you create an issue report please

ghost · 2018-10-04T12:18:04Z

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Can you create an issue report please

Created issue report #8326

ashok-rao

Thanks @ganesh-ramachandran ..left some comments.

ashok-rao · 2018-10-04T14:13:24Z

targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/spi_api.c

@@ -0,0 +1,284 @@
+/* mbed Microcontroller Library


@ganesh-ramachandran : I see the SPI API implemented but don't see the pin definitions in PinNames.h .. any reason??

Hi @ashok-rao, added the SPI pin definitions in PinNames.h

ashok-rao · 2018-10-04T14:15:56Z

targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/device/TOOLCHAIN_GCC_ARM/tmpm3hqfdfg.ld

+/* Linker script to configure memory regions. */
+MEMORY
+{
+  FLASH (rx) : ORIGIN = 0x00000000, LENGTH = 512K


I didn't find the "MBED_APP_START" macro.. any reason not to have this defined in all the 3 toolchain's linker descriptions?

Hi @ashok-rao, added "MBED_APP_START" macro in all 3 toolchain's linker descriptions.

ashok-rao · 2018-10-04T14:16:35Z

targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/PinNames.h

+    SW2 = PV1,
+    SW3 = PV2,
+    SW4 = PV3,
+


@ganesh-ramachandran : No SPI pins brought out on the board?

Hi @ashok-rao, added the SPI pin definitions in PinNames.h

ashok-rao · 2018-10-04T14:17:06Z

targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/PinNames.h

+    SW1 = PV0,
+    SW2 = PV1,
+    SW3 = PV2,
+    SW4 = PV3,


Can you please create an alias for "USER_BUTTON" just to maintain consistency with other mbed targets? Thanks.

Hi @ashok-rao, added the alias for "USER_BUTTON".

ashok-rao · 2018-10-04T14:20:26Z

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Can you try updating your htrun https://github.com/ARMmbed/htrun#installation-from-python-sources I'd recommend installing latest htrun from sources..

ghost · 2018-10-05T10:19:53Z

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Can you try updating your htrun https://github.com/ARMmbed/htrun#installation-from-python-sources I'd recommend installing latest htrun from sources..

Installed the latest htrun from given link.
But getting same error by executing single test command.

ashok-rao · 2018-10-05T16:31:33Z

Strange.. That unicode error should not be present in the latest build of htrun.. can you try updating your greentea as well? It's most probably a python issue somewhere rather than the implementation..

ghost · 2018-10-09T06:16:05Z

Strange.. That unicode error should not be present in the latest build of htrun.. can you try updating your greentea as well? It's most probably a python issue somewhere rather than the implementation..

Hi @ashok-rao, we have updated the greentea as well as all the tools but getting same error.

Below is the versions of different tools:

- Windows		: 8.1 pro – 64 bit
- Python		: 2.7.14
- Mbed-cli		: 1.8.2
- Greentea		: 1.4.0
- Mbedhtrun		: 1.4.1
- Pip			: 18.1
- Git Bash(git)		: 2.15.1.windows.2
- Mercurial(hg)		: 4.5

And traceback report we have attached in issue #8326 (comment)

ashok-rao · 2018-10-10T18:38:52Z

@theotherjimmy .. any thoughts why htrun might be failing with unicode errors?

ghost · 2018-10-15T12:57:20Z

Hi @ashok-rao since htrun/single test having issues with latest mbed, could we post the results of single test with mbed v5.9.6 to progress this PR.

ashok-rao · 2018-10-15T13:39:56Z

I'm afraid this PR would need everything with the version of Mbed OS it was ported against @ganesh-ramachandran .. sorry about that!

0xc0170 · 2018-10-24T12:40:10Z

@ganesh-ramachandran Getting back to this . Is there any update? Tests are passing as I understood. Only singletest.py problem was there (@cmonr reminder to review the referenced issue above).

This needs a rebase.

cmonr · 2018-10-24T14:25:34Z

@0xc0170 Yup! (Finally have bandwidth to)

ghost · 2018-10-25T09:23:59Z

@ganesh-ramachandran Getting back to this . Is there any update? Tests are passing as I understood. Only singletest.py problem was there (@cmonr reminder to review the referenced issue above).

This needs a rebase.

@0xc0170 Only singletest has problem. Other than that no updates. Rebased.

0xc0170 · 2018-10-25T09:26:49Z

As this new target is only for Mbed OS 5, the singletest issue should not gate this.

I'll review shortly. @ashok-rao is OoO this week, expecting a review early next week (or @MarceloSalazar can review instead?)

0xc0170 · 2018-10-25T09:32:47Z

targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/device/cmsis.h

@@ -0,0 +1,13 @@
+/* mbed Microcontroller Library - CMSIS for TMPM3HQ


Should be the same license header as in other files targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/gpio_api.c .

Also cmsis_nvic.h

Updated the license header

0xc0170 · 2018-10-25T09:36:13Z

I would like to test exporters (new device name, IAR) to check if we need an update in our CI

/morph export-build

mbed-ci · 2018-10-25T12:34:08Z

Exporter Build : FAILURE

Build number : 3080
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8324/

0xc0170 · 2018-10-25T12:44:54Z

I'll request new cmsis pack for this device.

What IAR version is required ? If it is not supported in IAR 7.8, we should remove this from iar definitions. Until we get IAR 8.x support

0xc0170 · 2018-10-25T12:47:18Z

Created internal ticket IOTTESTINF-4538 for cmsis-pack update

cmonr · 2018-10-25T15:07:33Z

@ganesh-ramachandran Would you happen to know exactly which CMSIS pack is needed for this new target?

ghost · 2018-10-26T06:53:40Z

What IAR version is required ? If it is not supported in IAR 7.8, we should remove this from iar definitions. Until we get IAR 8.x support

Hi @0xc0170 IAR version 8.22 is required for TMPM3HQ. Hence removed from iar definitions.

@ganesh-ramachandran Would you happen to know exactly which CMSIS pack is needed for this new target?

https://www.keil.com/dd2/toshiba/tmpm3hqfdfg/

ashok-rao · 2018-11-05T12:33:15Z

targets/targets.json

+        "is_disk_virtual": true,
+        "extra_labels": ["TOSHIBA"],
+        "macros": ["__TMPM3HQ__"],
+        "supported_toolchains": ["GCC_ARM", "ARM", "IAR"],


@ganesh-ramachandran : If we are removing IAR support until mbed OS supports IAR 8.x, then "IAR" from supported_toolchains should be removed too. Thanks.

@ganesh-ramachandran : If we are removing IAR support until mbed OS supports IAR 8.x, then "IAR" from supported_toolchains should be removed too. Thanks.

It should compile it (needs core), so can stay as it is, just definition removal

ashok-rao · 2018-11-05T12:40:31Z

@0xc0170 / @cmonr : This PR is looking good now - except for CMSIS pack update in our CI and IAR support removed in the PR (this comment..until 8.x support is available), it should be good to go through CI..also note the 1 failing GT test (#8326 )

0xc0170 · 2018-11-05T13:20:04Z

IOTTESTINF-4538

The ticket is in progress, we will report back once the pack is in place. Sorry for the delay

Since not supported in IAR 7.8, removed from iar definitions.

0xc0170 · 2018-11-08T11:42:30Z

CI machine was updated.

/morph build

mbed-ci · 2018-11-08T14:23:38Z

Build : FAILURE

Build number : 3581
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8324/

0xc0170 · 2018-11-08T14:28:40Z

Known issue with CI, we are investigating

cmonr · 2018-11-09T03:58:34Z

/morph build

mbed-ci · 2018-11-09T04:52:15Z

Build : SUCCESS

Build number : 3587
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8324/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-11-09T05:57:49Z

Exporter Build : SUCCESS

Build number : 3197
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8324/

mbed-ci · 2018-11-09T07:57:46Z

Test : SUCCESS

Build number : 3363
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8324/3363

0xc0170 added the needs: review label Oct 4, 2018

0xc0170 requested a review from ashok-rao October 4, 2018 11:42

ashok-rao reviewed Oct 4, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Oct 4, 2018

0xc0170 added the scope: new-target label Oct 24, 2018

0xc0170 requested changes Oct 25, 2018

View reviewed changes

ashok-rao reviewed Nov 5, 2018

View reviewed changes

Added Support for TOSHIBA TMPM3HQ

7d93fb4

Ganesh Ramachandran added 3 commits November 5, 2018 19:54

Added MBED_APP_START and SPI pin definitions

4cbdfb3

Updated license header

ac7bb55

Removed IAR export definition for M3HQ

beaa0da

Since not supported in IAR 7.8, removed from iar definitions.

0xc0170 added needs: CI and removed needs: work labels Nov 8, 2018

0xc0170 approved these changes Nov 8, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Nov 9, 2018

0xc0170 merged commit 662b744 into ARMmbed:master Nov 9, 2018

0xc0170 removed the ready for merge label Nov 9, 2018

ghost deleted the m3hq_new_target branch November 9, 2018 09:46

cmonr added the release-version: 5.10.4 label Nov 9, 2018

		@@ -0,0 +1,13 @@
		/* mbed Microcontroller Library - CMSIS for TMPM3HQ

Add Support for TOSHIBA TMPM3HQ #8324

Add Support for TOSHIBA TMPM3HQ #8324

Uh oh!

Conversation

ghost commented Oct 4, 2018

Description

Pull request type

Uh oh!

0xc0170 commented Oct 4, 2018

Uh oh!

ghost commented Oct 4, 2018

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashok-rao commented Oct 4, 2018

Uh oh!

ghost commented Oct 5, 2018

Uh oh!

ashok-rao commented Oct 5, 2018

Uh oh!

ghost commented Oct 9, 2018

Uh oh!

ashok-rao commented Oct 10, 2018

Uh oh!

ghost commented Oct 15, 2018

Uh oh!

ashok-rao commented Oct 15, 2018

Uh oh!

0xc0170 commented Oct 24, 2018

Uh oh!

cmonr commented Oct 24, 2018

Uh oh!

ghost commented Oct 25, 2018

Uh oh!

0xc0170 commented Oct 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 25, 2018

Uh oh!

mbed-ci commented Oct 25, 2018

Uh oh!

0xc0170 commented Oct 25, 2018

Uh oh!

0xc0170 commented Oct 25, 2018

Uh oh!

cmonr commented Oct 25, 2018

Uh oh!

ghost commented Oct 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashok-rao commented Nov 5, 2018

Uh oh!

0xc0170 commented Nov 5, 2018

Uh oh!

0xc0170 commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Nov 8, 2018 •

edited

Loading