Skip to content

Fix for HW CRC calculations on Silicon Labs targets #8026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2018

Conversation

stevew817
Copy link
Contributor

Description

Fixes the issue discovered in #8011. In short, 32-bit writes to the hardware CRC engine can only happen for a 32-bit polynomial. The reason this had not been discovered earlier is that the tests, when compiled with a release profile (which is the default) are likely to have non-aligned strings, which caused the CRC input code to go into byte-per-byte copy mode and never exercise the word-copy mode.

Verified by running both tests-mbed_hal-crc and tests-mbed_drivers-crc on both a release and debug profile.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 7, 2018

cc @studavekar

Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, just nit-picking on style.

@stevew817
Copy link
Contributor Author

@kjbracey-arm I applied changes according to your style comments. Can we get this fix in?

@cmonr
Copy link
Contributor

cmonr commented Sep 22, 2018

/moprh build

@stevew817
Copy link
Contributor Author

@cmonr typo? :)

@cmonr
Copy link
Contributor

cmonr commented Sep 23, 2018

Typo...

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2018

Build : SUCCESS

Build number : 3135
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8026/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants