-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix for HW CRC calculations on Silicon Labs targets #8026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @studavekar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, just nit-picking on style.
@kjbracey-arm I applied changes according to your style comments. Can we get this fix in? |
/moprh build |
@cmonr typo? :) |
Typo... /morph build |
Build : SUCCESSBuild number : 3135 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2743 |
Test : SUCCESSBuild number : 2940 |
Description
Fixes the issue discovered in #8011. In short, 32-bit writes to the hardware CRC engine can only happen for a 32-bit polynomial. The reason this had not been discovered earlier is that the tests, when compiled with a release profile (which is the default) are likely to have non-aligned strings, which caused the CRC input code to go into byte-per-byte copy mode and never exercise the word-copy mode.
Verified by running both
tests-mbed_hal-crc
andtests-mbed_drivers-crc
on both a release and debug profile.Pull request type