Skip to content

Cellular: state machine and easycellular now return error fast if sim… #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Cellular: state machine and easycellular now return error fast if sim… #7978

merged 1 commit into from
Oct 4, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Sep 4, 2018

… pin needed but not provided.

Description

State machine and easycellular now return error fast if sim pin needed but not provided.
In earlier implementation state machine tried to enter pin multiple times even no pin was provided.

Internal ref to defect: IOTCELL-1320

@AriParkkila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team September 4, 2018 11:39
AriParkkila
AriParkkila approved these changes Sep 7, 2018
View reviewed changes
Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well commented 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

Build : SUCCESS

Build number : 3154
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7978/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

Exporter Build : SUCCESS

Build number : 2758
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7978/

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

Will restart test after 5.10.1 RC is completed

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 3, 2018

Test : SUCCESS

Build number : 3020
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7978/3020

@0xc0170 0xc0170 merged commit 2247494 into ARMmbed:master Oct 4, 2018
@jarvte jarvte deleted the fix_cellular_no_pin branch October 22, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jarvte @0xc0170 @mbed-ci @AnttiKauppila @AriParkkila @NirSonnenschein