Cellular: Added power and sim greentea and unit tests. #7146

jarvte · 2018-06-06T12:10:41Z

Description

created power and sim greentea tests
added more power and sim unit tests.
added 'int do_reset' param to API CellularPower method "virtual nsapi_error_t set_power_level(int func_level, int do_reset = 1);"
This does not affect to current behaviour as default value is 1 and then it behaves in the old way.
AT_CellularSIM::get_imsi(char *imsi) now returns with NSAPI_ERROR_PARAMETER if the given imsi is null. This changes how method behaves but it fixes a crash (and invalid usage of method) so should not make a difference if one thinks this as a API change.

Internal ref to defect: IOTCELL-903-916

@mirelachirica @AnttiKauppila please review.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

jarvte · 2018-06-11T12:05:37Z

@0xc0170 could you please trigger the tests?

cmonr · 2018-06-12T03:12:24Z

/morph build

cmonr · 2018-06-12T03:14:17Z

features/cellular/framework/API/CellularPower.h

     *
     *  @remark See 3GPP TS 27.007 CFUN for more details
     *
     *  @return zero on success
     */
-    virtual nsapi_error_t set_power_level(int func_level) = 0;
+    virtual nsapi_error_t set_power_level(int func_level, int do_reset = 1) = 0;


Marking for 5.10 due to the API addition.

Otherwise, LGTM.

mbed-ci · 2018-06-12T06:51:50Z

Build : SUCCESS

Build number : 2327
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7146/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

0xc0170 · 2018-06-12T08:37:27Z

features/cellular/TESTS/api/cellular_power/main.cpp

+    MBED_ASSERT(err == NSAPI_ERROR_OK);
+    wait_for_power(pwr);
+
+    /*


Why are we leaving this dead code in? What is the purpose

test code made but wasn't able to test it. We will test and uncomment it once we got bg96 to raas & ci.

I would rather leave it out rather commented-out code on master (stash it or push it to your local branch). Once tested, will be added

commented test removed.

mbed-ci · 2018-06-12T09:42:14Z

Exporter Build : FAILURE

Build number : 1950
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7146/

0xc0170 · 2018-06-12T11:29:37Z

/morph build

mbed-ci · 2018-06-13T08:31:29Z

Test : SUCCESS

Build number : 2108
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7146/2108

0xc0170 · 2018-06-13T09:17:09Z

Test result is from the previous changeset, we will need to restart CI again

cmonr · 2018-06-13T14:04:46Z

/morph build

mbed-ci · 2018-06-13T18:00:36Z

Build : SUCCESS

Build number : 2343
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7146/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-13T20:06:25Z

Exporter Build : SUCCESS

Build number : 1967
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7146/

mbed-ci · 2018-06-14T18:31:23Z

Test : SUCCESS

Build number : 2128
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7146/2128

cmonr · 2018-06-14T22:28:54Z

Crud. @jarvte Looks like this'll need a rebase and anther pass through CI...

cmonr · 2018-06-15T21:56:40Z

/morph build

mbed-ci · 2018-06-16T00:05:35Z

Build : SUCCESS

Build number : 2359
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7146/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-16T02:53:20Z

Exporter Build : FAILURE

Build number : 1984
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7146/

mbed-ci · 2018-06-16T03:50:36Z

Test : SUCCESS

Build number : 2147
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7146/2147

jarvte · 2018-06-18T07:32:11Z

@cmonr ci-morph-exporter failure not related to this pr

0xc0170 · 2018-06-18T07:51:23Z

/morph export-build

mbed-ci · 2018-06-18T09:39:37Z

Exporter Build : FAILURE

Build number : 1991
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7146/

0xc0170 · 2018-06-18T10:11:14Z

/morph export-build

mbed-ci · 2018-06-18T12:48:12Z

Exporter Build : SUCCESS

Build number : 1996
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7146/

0xc0170 · 2018-06-18T13:06:51Z

@ARMmbed/mbed-os-wan Please rereview (can't see here any approvals)

jarvte · 2018-06-19T08:00:19Z

@cmonr please approve and merge

cmonr · 2018-06-19T13:53:04Z

@jarvte I was looking at this again, and was wondering something.

added 'int do_reset' param to API CellularPower method "virtual nsapi_error_t set_power_level(int func_level, int do_reset = 1);"
This does not affect to current behaviour as default value is 1 and then it behaves in the old way.

I marked this for 5.10 because of the code addition in features/cellular/framework/AT/AT_CellularPower.cpp that adds _at.write_int(do_reset); and modifies the default behavior.

Could you explain how do_reset = 1 does not affect the previous behavior, when it looks like its addition results in a new reset behavior? I'm trying to make sure this is targeted to the proper release.

jarvte · 2018-06-20T05:59:33Z

@cmonr this is actually a bug, I read spec again and noticed that default value should be ''0'. If you don't give that do_reset if same as not doing the reset for the modem before applying the new functionality. I will fix default value to '0' in next PR for network tests.

jarvte · 2018-06-20T06:19:57Z

PR with the fix: #7269

cmonr · 2018-06-20T13:45:51Z

@jarvte Wonderful! Since that was my only holdover for making this target a feature release, I'll mark it back for the next patch release.

0xc0170 requested a review from a team June 6, 2018 12:34

0xc0170 added the needs: review label Jun 6, 2018

AnttiKauppila previously approved these changes Jun 6, 2018

View reviewed changes

cmonr previously approved these changes Jun 12, 2018

View reviewed changes

cmonr added needs: CI release-version: 5.10.0-rc1 and removed needs: review labels Jun 12, 2018

0xc0170 requested changes Jun 12, 2018

View reviewed changes

jarvte dismissed stale reviews from cmonr and AnttiKauppila via 9056036 June 12, 2018 11:24

jarvte force-pushed the add_cellular_sim_and_power_tests branch from 7e21829 to 9056036 Compare June 12, 2018 11:24

0xc0170 previously approved these changes Jun 12, 2018

View reviewed changes

cmonr added needs: work and removed needs: CI labels Jun 14, 2018

Cellular: Added power and sim greentea and unit tests.

7e1b048

jarvte dismissed 0xc0170’s stale review via 7e1b048 June 15, 2018 06:03

jarvte force-pushed the add_cellular_sim_and_power_tests branch from 9056036 to 7e1b048 Compare June 15, 2018 06:03

Cellular: fixed unit tests after rebase with latest changes.

f821b02

0xc0170 added needs: CI and removed needs: work labels Jun 15, 2018

0xc0170 requested a review from a team June 18, 2018 13:06

cmonr added needs: review and removed needs: CI labels Jun 18, 2018

AriParkkila approved these changes Jun 19, 2018

View reviewed changes

cmonr approved these changes Jun 19, 2018

View reviewed changes

cmonr added ready for merge and removed needs: review labels Jun 19, 2018

cmonr merged commit d1dc1e8 into ARMmbed:master Jun 19, 2018

0xc0170 removed the ready for merge label Jun 19, 2018

jarvte deleted the add_cellular_sim_and_power_tests branch June 20, 2018 06:46

cmonr added release-version: 5.9.2 and removed release-version: 5.10.0-rc1 labels Jun 20, 2018

jarvte mentioned this pull request Jun 25, 2018

Cellular: add cellular network tests #7269

Merged

Cellular: Added power and sim greentea and unit tests. #7146

Cellular: Added power and sim greentea and unit tests. #7146

Uh oh!

Conversation

jarvte commented Jun 6, 2018

Description

Pull request type

Uh oh!

jarvte commented Jun 11, 2018

Uh oh!

cmonr commented Jun 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Jun 12, 2018

Triggering tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Jun 12, 2018

Uh oh!

0xc0170 commented Jun 12, 2018

Uh oh!

mbed-ci commented Jun 13, 2018

Uh oh!

0xc0170 commented Jun 13, 2018

Uh oh!

cmonr commented Jun 13, 2018

Uh oh!

mbed-ci commented Jun 13, 2018

Triggering tests

Uh oh!

mbed-ci commented Jun 13, 2018

Uh oh!

mbed-ci commented Jun 14, 2018

Uh oh!

cmonr commented Jun 14, 2018

Uh oh!

cmonr commented Jun 15, 2018

Uh oh!

mbed-ci commented Jun 16, 2018

Triggering tests

Uh oh!

mbed-ci commented Jun 16, 2018

Uh oh!

mbed-ci commented Jun 16, 2018

Uh oh!

jarvte commented Jun 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jun 18, 2018

Uh oh!

mbed-ci commented Jun 18, 2018

Uh oh!

0xc0170 commented Jun 18, 2018

Uh oh!

mbed-ci commented Jun 18, 2018

Uh oh!

0xc0170 commented Jun 18, 2018

Uh oh!

jarvte commented Jun 19, 2018

Uh oh!

cmonr commented Jun 19, 2018

Uh oh!

jarvte commented Jun 20, 2018

Uh oh!

jarvte commented Jun 20, 2018

Uh oh!

cmonr commented Jun 20, 2018

Uh oh!

Uh oh!

jarvte commented Jun 18, 2018 •

edited

Loading