Add support for the WISE1530 and integration framework for WICED SDK #5758

geky · 2017-12-21T23:15:23Z

Add support for the WISE1530 and integration framework for WICED SDK

This is a squash of a long series of work that introduces the WICED SDK into Mbed OS. Allowing the use of the WISE1530Interface in Mbed OS.

The WICED SDK requires additional steps to integrate into Mbed OS before it can be used. For more information see WICED.md.

cc @pan-, @SeppoTakalo, @SenRamakri, @sg-, @AnotherButler

0xc0170 · 2017-12-22T12:55:41Z

targets/TARGET_WICED/TARGET_WISE1530_F412RE/wise1530_emac.c

@@ -0,0 +1,208 @@
+#include "mbed_assert.h"


license header here please

0xc0170 · 2017-12-22T12:55:54Z

targets/TARGET_WICED/TARGET_WISE1530_F412RE/wise1530_emac.c

+
+/* notify link is up or down
+ */
+wiced_result_t wiced_network_notify_link_up(void) {


{ new line

0xc0170 · 2017-12-22T13:04:56Z

targets/TARGET_WICED/wiced_port/WICED/network/mbed/WWD/wwd_buffer.c

+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#if defined (IAR_TOOLCHAIN)


should use IAR identifier rather here

why a header file inclusion is based on the toolchain?

This file had a lot of revisions, I'll see if I can remove it when I can.

0xc0170 · 2017-12-22T13:09:31Z

targets/TARGET_WICED/wiced_port/WICED/network/mbed/WWD/wiced_network.h

+ * limitations under the License.
+ */
+#pragma once
+#if 0


this is external file and imported as is (so this deadcode is in there) ? same for typedef below

Oh good catch, will remove

0xc0170 · 2017-12-22T13:11:32Z

targets/TARGET_WICED/wiced_port/WICED/RTOS/mbed/WWD/wwd_rtos.cpp

+#include "wwd_assert.h"
+#include "wwd_rtos_interface.h"
+#include "wiced_utilities.h"
+#include "mbed.h"


should not include this , pull in what is needed rather

Above comment got hidden by changes, but question still stands:

Is this a problem in cpp files? There's no risk of namespace polution since it's self contained in the cpp file. If anything this would help protect against filename changes.

Including only header files that you need will greatly reduce the rebuild time.

On the first build, dependency files are created. Then on the following builds, if there has not been any changes to those headers that you include, your file is not needed to rebuild.

But if everyone includes "mbed.h" this leads every small change to lead to full rebuild of the whole Mbed OS tree.

Fair enough, will update

0xc0170 · 2017-12-22T13:12:08Z

targets/TARGET_WICED/wiced_port/WICED/RTOS/mbed/WWD/wwd_rtos.cpp

+#include "ticker_api.h"
+
+
+/**


are these docs needed here? Not done in the header file? If they are, this is duplicate and pollutes code file

They're copied from the header file, but the header file is hard to track down. I can remove them if we'd like.

0xc0170 · 2017-12-22T13:14:34Z

targets/TARGET_WICED/TARGET_WISE1530_F412RE/WISE1530Interface.cpp

+
+#include "WISE1530Interface.h"
+
+#include "mbed.h"


dont include this header file outside of user space

Oh, is this a problem in cpp files? There's no risk of namespace polution since it's self contained in the cpp file. If anything this would help protect against filename changes.

As I understand it, a name.cpp file should only ever include its name.h file, for stylistic reasons, not technical.

adbridge · 2017-12-29T13:32:43Z

@0xc0170 Could you re-review please?

0xc0170 · 2018-01-02T18:58:51Z

Please review travis, docs and tools report related errors.

geky · 2018-01-02T19:33:56Z

I may need help, @theotherjimmy:

Bad Assembler file name found: ./targets/TARGET_STM/TARGET_STM32F4/TARGET_Advantech_F412RE/device/TOOLCHAIN_GCC_ARM/startup_stm32f412rx.s
Bad Assembler file name found: ./targets/TARGET_STM/TARGET_STM32F4/TARGET_Advantech_F412RE/device/TOOLCHAIN_ARM_MICRO/startup_stm32f412rx.s
Bad Assembler file name found: ./targets/TARGET_STM/TARGET_STM32F4/TARGET_Advantech_F412RE/device/TOOLCHAIN_ARM_STD/startup_stm32f412rx.s
Bad Assembler file name found: ./targets/TARGET_STM/TARGET_STM32F4/TARGET_Advantech_F412RE/device/TOOLCHAIN_IAR/startup_stm32f412rx.s

What are valid assembly names?

AssertionError: Target WISE1530_F412RE contains invalid device_name Advantech_F412RE
E           assert 'Advantech_F412RE' in {'AC30M1332': {'algorithm': {'AC30M1x64/Flashloader/AC30M1x64_64.FLM': {'default': '1', 'ramsize': None, 'ramstart': N...header': 'AC30M1x64/Core/include/AC30M1x64.h'}, 'core': 'Cortex-M0', 'debug': 'AC30M1x64/SVD/AC30M1x64.svd', ...}, ...}
E            +  where 'Advantech_F412RE' = Target(name='WISE1530_F412RE', json_data={'WISE1530_F412RE': OrderedDict([('in...et', 2)], resolution_order_names=['WISE1530_F412RE', 'FAMILY_STM32', 'Target']).device_name
E            +  and   {'AC30M1332': {'algorithm': {'AC30M1x64/Flashloader/AC30M1x64_64.FLM': {'default': '1', 'ramsize': None, 'ramstart': N...header': 'AC30M1x64/Core/include/AC30M1x64.h'}, 'core': 'Cortex-M0', 'debug': 'AC30M1x64/SVD/AC30M1x64.svd', ...}, ...} = <tools.arm_pack_manager.Cache instance at 0x7fc444886f38>.index

This means I don't have a pack for the target I think? I'm not entirely sure what this response to this assertion should be.

geky · 2018-01-02T19:38:37Z

Ah, sorry @AnotherButler I should have clarified. The WICED.md file is probably the only document worth editing:
https://github.com/geky/mbed/blob/3d44874f24460c23782d194b259d6efdfc776da7/targets/TARGET_WICED/WICED.md

The code you're editing predates me, I don't know if it's valuable to edit and I can't vouch that the edits are keeping the documentation's meaning correct, sorry.

AnotherButler · 2018-01-02T19:41:48Z

@geky Thanks for the clarification.

0xc0170 · 2018-01-03T10:24:57Z

.s - suffix should be upper case to be portable, thus please rename them to have .S
Advantech_F412RE - does it have cmsis-pack? If yes, then is this a correct name?

geky · 2018-01-03T17:58:23Z

Thanks, will update the assembly file.

I'll have to look into the cmsis pack thing more. Where does one normally find cmsis packs? Do they need to be generated?

0xc0170 · 2018-01-03T19:18:37Z

I'll have to look into the cmsis pack thing more. Where does one normally find cmsis packs? Do they need to be generated?

Yes, a vendor generates a pack and publishes it (device support as it is called there). You can use the arm pack manager that is part of this repo, or check in the uVision for instance (it has the pack installer to check if target is there). If there is not, we shall remove device_name. @theotherjimmy can provide more info in this area

KariHaapalehto · 2018-01-05T08:19:05Z

Should we rename folder mbed-os\targets\TARGET_WICED\TARGET_WISE1530_F412RE\ and files under that folder? Those files are not hw specifig files just for wise1530, they are more like wiced adaptation to mbed and can be used with other variants too.

KariHaapalehto

Here are my comments to WICED.mk

KariHaapalehto · 2018-01-05T10:00:39Z

targets/TARGET_WICED/WICED.md

+- mbed_lib.json
+
+## Download the WICED SDK
+


Here are two different instructions, so I would add comment:
"Both WICED SDK and patch from Advantech is needed"

Added to section header

KariHaapalehto · 2018-01-05T10:01:17Z

targets/TARGET_WICED/WICED.md

+on Advantech's Wiki:
+http://ess-wiki.advantech.com.tw/view/WISE-1530_SDK
+
+To get the WICED SDK, download WICED-Studio-5.2.0 for your platform:


Or WICED SDK WICED-Studio-5.2.0 for your platform can be get here:

Hi @KariHaapalehto, I'm not exactly sure what the suggestion is for this line. Does the studio need to be named "WICED SDK WICED-Studio-5.2.0"?

Well, that's not right, the studio is WICED-Studio-5.2.0. Inside the studio you get the WICED SDK.

KariHaapalehto · 2018-01-05T10:01:41Z

targets/TARGET_WICED/WICED.md

+To get the WICED SDK, download WICED-Studio-5.2.0 for your platform:
+https://community.cypress.com/community/wiced-wifi/wiced-wifi-documentation
+
+Once downloaded, move the WICED SDK folder into `targets/TARGET_WICED`.


Once downloaded, move the SDK's targets/TARGET_WICED/43xxx_Wi-Fi-folder into targets/TARGET_WICED.

Also added note about rename to WICED

KariHaapalehto · 2018-01-05T10:02:13Z

targets/TARGET_WICED/WICED.md

+For the WISE1530, download the patch from Advantech:
+`WM-BN-BM-22_SDK_5.1.x_platform_patch.zip`
+
+Once downloaded, copy the contents into `targets/TARGET_WICED/WICED`.


Once downloaded, copy the contents into targets/TARGET_WICED.

It really should be targets/TARGET_WICED/WICED (after rename). Otherwise the libraries/platforms folders don't line up with their destinations. Note there are multiple nested WICED folders.

KariHaapalehto · 2018-01-05T10:04:46Z

targets/TARGET_WICED/WICED.md

+
+1. Remove these files because they are unnecessary and large:
+   - `targets/TARGET_WICED/WICED/tools`
+   - `targets/TARGET_WICED/WICED/build`


There isn't build-directory

The build directory is generated if you compile using the WICED studio. I can go ahead and remove this if we want.

KariHaapalehto · 2018-01-05T10:10:28Z

targets/TARGET_WICED/WICED.md

+   Note this is required for the WISE1530 but may not be needed for other
+   platforms.
+
+1. Remove the includes of `w_core_cm4.h` and `w_core_cmFunc.h`, and replace the


KariHaapalehto · 2018-01-05T10:10:36Z

targets/TARGET_WICED/WICED.md

+   + #include "core_cm4.h"
+   ```
+
+1. Remove the padding of SDPCM data packets. This requires modifications in two


KariHaapalehto · 2018-01-05T10:10:56Z

targets/TARGET_WICED/WICED.md

+    } sdpcm_data_header_t;
+   ```
+
+   In `targets/TARGET_WICED/WICED/WWD/internal/w_wwd_sdpcm.c` line 1282:


KariHaapalehto · 2018-01-05T10:21:52Z

targets/TARGET_WICED/WICED.md

+   Note this is required for the WISE1530 but may not be needed for other
+   platforms.
+
+1. Set up SDIO_ENUMERATION_TIMEOUT_MS to be configurable. Mbed OS will override this,


KariHaapalehto · 2018-01-05T10:24:46Z

targets/TARGET_WICED/WICED.md

+     #define SDIO_ENUMERATION_TIMEOUT_MS          (500)
+   + #endif
+   ```
+


12 Rename ./mbed-os/targets/TARGET_WICED/TARGET_WISE1530_F412RE/wise1530_emac.c to ./mbed-os/targets/TARGET_WICED/TARGET_WISE1530_F412RE/wise1530_emac.cpp

Why is this needed? wise1530_emac.c is in Mbed OS, so we can change it here if need be.

But why does it need to be changed to cpp, was there a compilation issue?

SeppoTakalo · 2018-01-05T13:41:34Z

As this is only going for the feature branch and is a work in progress, I'm OK if this gets merged in as it is currently.

We will anyway continue on working to improve the instructions but at least we won't be blocking others to study it.

0xc0170

LGTM, just one comment

0xc0170 · 2018-01-10T11:55:43Z

features/FEATURE_BLE/targets/TARGET_WISE1530_F412RE/HCIDriver.cpp

+#include <stdio.h>
+#include "CordioBLE.h"
+#include "CordioHCIDriver.h"
+#include "mbed.h"


what is needed here from mbed.h ? DigitalInout and PinNames ?

missing license header file

looks like it was not used

new one done

cmonr · 2018-01-11T16:48:57Z

@0xc0170 @SeppoTakalo @KariHaapalehto Are you all happy with @geky's updates?

SeppoTakalo · 2018-01-11T16:55:29Z

I'm still in a process of going though the steps... I have not yet successfully build it.

SeppoTakalo · 2018-01-11T17:46:38Z

Final problem that I cannot get past

./mbed-os/targets/TARGET_WICED/WICED/libraries/drivers/gspi/gspi_slave/w_gspi_slave.c:38:28: fatal error: platform_cache.h: No such file or directory
 #include "platform_cache.h"

This platform_cache.h file was one that was excluded from the build because of .mbedignore lists its folder WICED/WICED/platform/ARM_CR4/

SeppoTakalo · 2018-01-11T17:51:23Z

Also, lots of files seems to be relying that #pragma once which is not working on GCC. Causing lots of warnings and some errors.

geky · 2018-02-01T17:03:06Z

Looks like it's almost good to go. @SeppoTakalo thanks for fixing that 👍

geky · 2018-02-01T17:24:33Z

@0xc0170, @cmonr, tests already failing for NUCLEO_F746ZG:

tests-mbed_drivers-lp_ticker
:170::FAIL: Values Not Within Delta 2000 Expected 10000 Was 12546

Is there something on master that makes lp-ticker more stable? or is this just a case of rerun?

mbed-ci · 2018-02-01T17:38:53Z

Test : FAILURE

Build number : 847
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5758/847

cmonr · 2018-02-01T17:48:46Z

I'll restart it. @geky, the only thing that I could really think of is if the CI machine running the test is being hit hard, and having issues keeping up with all of the communication with the Device Under Test.

/morph uvisor-test

cmonr · 2018-02-01T19:32:06Z

/morph test

cmonr · 2018-02-01T22:20:59Z

Sorry, but it looks like this PR is doing something to lp_ticker test with the NUCLEO_F746ZG. The device is working fine, as evidenced by its previous build (#5022 (comment)).

Results are about to be reported.

mbed-ci · 2018-02-01T22:38:11Z

Test : FAILURE

Build number : 851
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5758/851

kjbracey · 2018-02-08T15:52:53Z

Please rebase and resubmit - hopefully the cause of the failures should have been cleared on master.

This is a squash of a long series of work that introduces the WICED SDK into Mbed OS. Allowing the use of the WISE1530Interface in Mbed OS. The WICED SDK requires additional steps to integrate into Mbed OS before it can be used. For more information see WICED.md.

Copy edit for active voice, grammar and precise language.

0xc0170 · 2018-02-08T17:11:48Z

/morph build

mbed-ci · 2018-02-08T17:42:48Z

Build : SUCCESS

Build number : 1094
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5758/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-02-08T18:45:43Z

Exporter Build : SUCCESS

Build number : 772
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5758/

mbed-ci · 2018-02-08T21:19:25Z

Test : FAILURE

Build number : 902
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5758/902

mbed-ci · 2018-02-08T23:10:21Z

Test : SUCCESS

Build number : 903
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5758/903

geky · 2018-02-09T00:07:42Z

🎉

geky changed the base branch from master to feature-wiced December 21, 2017 23:15

0xc0170 added the needs: review label Dec 22, 2017

0xc0170 previously requested changes Dec 22, 2017

View reviewed changes

geky force-pushed the feature-wiced branch from 4095444 to a98b527 Compare December 27, 2017 21:34

0xc0170 added needs: work and removed needs: review labels Jan 2, 2018

KariHaapalehto reviewed Jan 5, 2018

View reviewed changes

geky force-pushed the feature-wiced branch 3 times, most recently from acc7539 to 5e135e4 Compare January 9, 2018 23:50

0xc0170 reviewed Jan 10, 2018

View reviewed changes

geky force-pushed the feature-wiced branch 2 times, most recently from d3f9aef to 516fd7b Compare January 11, 2018 15:45

cmonr added needs: CI and removed needs: work labels Jan 11, 2018

cmonr added the needs: CI label Feb 1, 2018

cmonr added needs: work and removed needs: CI labels Feb 1, 2018

geky and others added 7 commits February 8, 2018 10:57

Added WISE-1530 as mbed target

f7b3655

BLE: Add ble support for the Wise 1530 module.

d014085

Copy edit WICED.md

e91ccd1

Copy edit for active voice, grammar and precise language.

Editted WICED.md based on initial feedback

808e889

Disabled WICED compilation by default

3891eee

Fix test builds if WICED is not enabled.

021462b

geky force-pushed the feature-wiced branch from 44dfb29 to 021462b Compare February 8, 2018 16:57

geky changed the base branch from feature-wiced to master February 8, 2018 17:03

geky changed the base branch from master to feature-wiced February 8, 2018 17:04

cmonr removed the needs: work label Feb 8, 2018

cmonr merged commit 4de3f2f into ARMmbed:feature-wiced Feb 8, 2018

0xc0170 mentioned this pull request Jun 22, 2018

no wifi to wise 1530 #6400

Closed

Add support for the WISE1530 and integration framework for WICED SDK #5758

Add support for the WISE1530 and integration framework for WICED SDK #5758

Uh oh!

Conversation

geky commented Dec 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geky Dec 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geky Dec 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adbridge commented Dec 29, 2017

Uh oh!

0xc0170 commented Jan 2, 2018

Uh oh!

geky commented Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geky commented Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AnotherButler commented Jan 2, 2018

Uh oh!

0xc0170 commented Jan 3, 2018

Uh oh!

geky commented Jan 3, 2018

Uh oh!

0xc0170 commented Jan 3, 2018

Uh oh!

KariHaapalehto commented Jan 5, 2018

Uh oh!

KariHaapalehto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geky commented Dec 21, 2017 •

edited

Loading

geky Dec 22, 2017 •

edited

Loading

geky Dec 22, 2017 •

edited

Loading

geky commented Jan 2, 2018 •

edited

Loading

geky commented Jan 2, 2018 •

edited

Loading