Skip to content

STM32: Add support of Flash API for STM32F3 devices #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 4, 2018

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Dec 13, 2017

Description

  • Add support of Flash API for STM32F3 devices.
  • Activated on NUCLEO_F303RE and NUCLEO_F303ZE boards only (other F3 boards are not mbedOS5 compliant)
  • Flash tests OK --> report_test5_flash_STM32F303xE_ARM.txt

Status

READY

Migrations

NO

Related PRs

Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

return -1;
}

if ((size % MIN_PROG_SIZE) != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check needed, as the comment says , it is done by a caller

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this test is needed. The flash can only be programmed a certain amount of bytes at the time.

return status;
}

/** Program one page starting at defined address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed to have th same doc than in the header file? it will be out of sync one docs API will get any update. I would remove these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to remove it.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 22, 2017

@bcostm Please rebase to the latest master to get travis fix in place, we will trigger CI

@bcostm
Copy link
Contributor Author

bcostm commented Jan 2, 2018

Rebase done. No conflict.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2018

Build : SUCCESS

Build number : 779
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5697/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants