-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32: Add support of Flash API for STM32F3 devices #5697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
return -1; | ||
} | ||
|
||
if ((size % MIN_PROG_SIZE) != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this check needed, as the comment says , it is done by a caller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this test is needed. The flash can only be programmed a certain amount of bytes at the time.
return status; | ||
} | ||
|
||
/** Program one page starting at defined address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed to have th same doc than in the header file? it will be out of sync one docs API will get any update. I would remove these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to remove it.
@bcostm Please rebase to the latest master to get travis fix in place, we will trigger CI |
Rebase done. No conflict. |
/morph build |
Build : SUCCESSBuild number : 779 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 431 |
Test : SUCCESSBuild number : 615 |
Description
Status
READY
Migrations
NO
Related PRs