Fix echo test handshake and reduce uart load #5272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) if we receive more than one __sync, previous handshake would consider it as echo_count and try to decode the value. Now we skip superfluous __sync. 2) reduce the uart load produced by the test, as we are heavily running tests in parallel and not one-to-one this update was required.
|
morph test |
|
triggering of test since this would be important to get parallel tests in place. /morph test-nightly |
|
@bridadan can you please review |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
retest uvisor |
bridadan
approved these changes
Oct 9, 2017
| @@ -48,12 +53,10 @@ utest::v1::status_t greentea_failure_handler(const Case *const source, const fai | |||
|
|
|||
| Case cases[] = { | |||
| Case("Echo server: x16", test_case_echo_server_x<16>, greentea_failure_handler), | |||
| Case("Echo server: x32", test_case_echo_server_x<32>, greentea_failure_handler), | |||
| Case("Echo server: x64", test_case_echo_server_x<64>, greentea_failure_handler), | |||
There was a problem hiding this comment.
Seems ok, I'm guessing if any failures were to crop up in these cases it'd be a DAPlink related issue.
cc @c1728p9
theotherjimmy
changed the title
theotherjimmy
added
needs: CI
ready for merge
and removed
needs: review
needs: CI
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if we receive more than one __sync, previous handshake would consider
it as echo_count and try to decode the value. Now we skip superfluous __sync.
reduce the uart load produced by the test, as we are heavily running tests in
parallel and not one-to-one this update was required.
Status
IN DEVELOPMENT
Todos