Basic test refactoring #5243

maciejbocianski · 2017-10-03T08:05:47Z

Description

No functional changes only refactoring

Status

READY

pan- · 2017-10-03T09:10:39Z

TESTS/mbedmicro-rtos-mbed/basic/main.cpp

 #include "mbed.h"
 #include "greentea-client/test_env.h"
+#include "unity.h"


Please add the module to the inclusion path (see here).

In other words:

#include "unity/unity.h" #include "utest/utest.h" #include "rtos/rtos.h"

link is not found

I'm not sure why you cannot access the guidelines ( @0xc0170 any idea ? ). The guideline state:

* Header files should always be included using the module directory in the path. * examples: #include “lwip/lwip-interface.h”, #include “drivers/Ticker.h” * Limit the include path to only the module directory, this allows the module to be moved in the future.

pan-

Good refactoring. Additional changes might even make it better:

Is it necessary to have a second thread executing gt_comm_wait_thread ? That function is the test and can be executed in the test function running in the main thread.
A mutex shall protect access to the variable callback_trigger_count. volatile variables cannot be shared safely across different threads of execution.
There is two comments explaining what the test do: one at line 19 and the other as the documentation of the test function. It may be good to have a single comment block explaining how things work in detail.
Some entities names are not descriptive or misleading: for example callback_trigger_count doesn't mean anything, it is a counter in seconds and it is not invoked from a callback. May you improve entities naming ?

pan- · 2017-10-03T09:16:41Z

TESTS/mbedmicro-rtos-mbed/basic/main.cpp


 #if defined(MBED_RTOS_SINGLE_THREAD)
 #error [NOT_SUPPORTED] test not supported
 #endif

+using namespace utest::v1;


Would it be possible to import the symbols needed rather than the whole namespace ?

Generally I don't like importing anything, but rest of TEST code already use it. So I assumed that is prefered

If we don't want importing whole namespace we have to import following symbols:

using utest::v1::status_t; using utest::v1::Case; using utest::v1::Specification; using utest::v1::greentea_test_setup_handler; using utest::v1::greentea_test_teardown_handler; using utest::v1::Harness;

We do not have explicit rule on this item however, importing the minimal set of names used rather than the whole namespace may limit conflicts. We had some in the past with target code.

pan- · 2017-10-03T09:18:48Z

TESTS/mbedmicro-rtos-mbed/basic/main.cpp

-    Thread tick_thread(osPriorityHigh, TEST_STACK_SIZE);
+/** Test DUT<->host interaction
+
+    Given two threads (A & B) are started and thread A act as counter for time measure


Could you precise what thread B do ?

pan- · 2017-10-03T09:18:50Z

TESTS/mbedmicro-rtos-mbed/basic/main.cpp

+/** Test DUT<->host interaction
+
+    Given two threads (A & B) are started and thread A act as counter for time measure
+    When thread B initiates host communication and perform time measure test


It would be interesting to have a description of the "time measure test".

maciejbocianski · 2017-10-03T11:00:57Z

Generally I planned to do minimal changes to align this test to rest of the code from TEST folder.
But if we want to redesign it we can resign from threads and use ticker for time measure

maciejbocianski · 2017-10-03T13:41:05Z

@pan- Test was a bit redesigned

pan- · 2017-10-03T14:08:23Z

It is not only redesigned, from what I see the purpose of the test has also been changed.

Initially the purpose of the test was: Tests is to measure the accuracy of Thread::wait() over a period of time.

maciejbocianski · 2017-10-04T07:17:05Z

You are right
After further consideration I realised that after my changes test really test DUT-host communication not basis of RTOS. So I will revert it.

maciejbocianski · 2017-10-09T09:34:43Z

@pan- updated after review

pan-

Thanks for the refactoring

0xc0170 · 2017-10-11T14:05:43Z

/morph build

mbed-ci · 2017-10-11T16:10:08Z

Build : SUCCESS

Build number : 124
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5243/

Triggering tests

/test mbed-os

mbed-ci · 2017-10-12T19:28:56Z

Test : SUCCESS

Build number : 62
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5243/62

mbed-ci · 2017-10-16T15:13:04Z

Build : SUCCESS

Build number : 180
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5243/

Triggering tests

/test mbed-os

mbed-ci · 2017-10-16T16:19:23Z

Test : FAILURE

Build number : 77
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5243/77

0xc0170 · 2017-10-17T13:48:15Z

/morph build

mbed-ci · 2017-10-17T14:20:26Z

Build : SUCCESS

Build number : 197
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5243/

Triggering tests

/morph test

mbed-ci · 2017-10-17T19:14:47Z

Test : SUCCESS

Build number : 96
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5243/96

0xc0170 · 2017-10-18T12:21:11Z

/morph uvisor-test

mbed-ci · 2017-10-18T12:35:53Z

Build : SUCCESS

Build number : 223
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5243/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-18T15:30:50Z

Test : SUCCESS

Build number : 112
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5243/112

0xc0170 · 2017-10-19T07:09:32Z

/morph uvisor-test

pan- reviewed Oct 3, 2017

View reviewed changes

pan- requested changes Oct 3, 2017

View reviewed changes

maciejbocianski force-pushed the basic_tests branch 2 times, most recently from b92ee4e to cc4b406 Compare October 3, 2017 13:26

0xc0170 added the needs: review label Oct 4, 2017

maciejbocianski force-pushed the basic_tests branch from cc4b406 to 8f5d93f Compare October 9, 2017 09:32

Basic test refactoring

73a91e0

maciejbocianski force-pushed the basic_tests branch from 8f5d93f to 73a91e0 Compare October 9, 2017 11:27

pan- approved these changes Oct 11, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 11, 2017

theotherjimmy added ready for merge and removed needs: CI labels Oct 13, 2017

adbridge added needs: CI and removed ready for merge labels Oct 16, 2017

0xc0170 approved these changes Oct 17, 2017

View reviewed changes

0xc0170 added ready for merge release-version: 5.6.3 and removed needs: CI labels Oct 19, 2017

0xc0170 merged commit 919e145 into ARMmbed:master Oct 19, 2017

0xc0170 removed the ready for merge label Oct 19, 2017

Basic test refactoring #5243

Basic test refactoring #5243

Uh oh!

Conversation

maciejbocianski commented Oct 3, 2017

Description

Status

Uh oh!

pan- Oct 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pan- left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maciejbocianski commented Oct 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maciejbocianski commented Oct 3, 2017

Uh oh!

pan- commented Oct 3, 2017

Uh oh!

maciejbocianski commented Oct 4, 2017

Uh oh!

maciejbocianski commented Oct 9, 2017

Uh oh!

pan- left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 11, 2017

Uh oh!

mbed-ci commented Oct 11, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 12, 2017

Uh oh!

mbed-ci commented Oct 16, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 16, 2017

Uh oh!

0xc0170 commented Oct 17, 2017

Uh oh!

mbed-ci commented Oct 17, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 17, 2017

Uh oh!

0xc0170 commented Oct 18, 2017

Uh oh!

mbed-ci commented Oct 18, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 18, 2017

Uh oh!

0xc0170 commented Oct 19, 2017

Uh oh!

Uh oh!

pan- Oct 3, 2017 •

edited

Loading

maciejbocianski commented Oct 3, 2017 •

edited

Loading